[jira] [Commented] (WICKET-5241) RequestLogger's server duration does not include 'detach duration'

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920962#comment-13920962 ] 

Martin Grigorov commented on WICKET-5241:
-----------------------------------------

When someone starts working on this task (s)he may also take a look at the strange synchronization on a field that is re-assigned in the synchronization block: https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java?source=c#L458

> RequestLogger's server duration does not include 'detach duration'
> ------------------------------------------------------------------
>
>                 Key: WICKET-5241
>                 URL: https://issues.apache.org/jira/browse/WICKET-5241
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.6.0
>            Reporter: Chris Gunnink
>            Priority: Minor
>              Labels: performance
>
> When a certain IModel impl takes a lot of time to detach, this will not be included in the 'duration' section. This is very easy to reproduce: use a model that sleeps for 10 seconds in the detach(); make sure to write a page which will not much time to render, say 100ms. One will see that the RequestLogger will output 100ms as duration, instead of 10100ms.
> In our production environment, these this server duration is the primary metric to show server performance; so right now we're dealing with misleading figures.
> I hope this is an easy one to fix ;-)



--
This message was sent by Atlassian JIRA
(v6.2#6252)