[jira] [Comment Edited] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

["Andrei Dulceanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858191#comment-15858191 ] 

Andrei Dulceanu edited comment on OAK-5604 at 2/9/17 12:27 PM:
---------------------------------------------------------------

[~frm], thanks for reviewing! Regarding your comments, they make a lot of sense. My decision was to have another "quick, dirty & reliable" patch, as for OAK-5595, and to postpone further refactoring (OAK-5620) and left over removal for a dedicated issue. I wanted to start working on the refactoring only after OAK-5600, in order  to be sure that I didn't break something.

So if you are ok with the explanation above, I will commit the dirty patch for now and handle the points mentioned in a separate issue. WDYT?

/cc [~mduerig]


was (Author: dulceanu):
[~frm], thanks for reviewing! Regarding your comments, they make a lot of sense. My decision was to have another "quick, dirty & reliable" patch, as for OAK-5595, and to postpone further refactoring (see suggestion from OAK-5556) and left over removal for a dedicated issue. I wanted to start working on the refactoring only after OAK-5600, in order  to be sure that I didn't break something.

So if you are ok with the explanation above, I will commit the dirty patch for now and handle the points mentioned in a separate issue. WDYT?

/cc [~mduerig]

> The check command should accept a non-argument "bin" option for checking binaries
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-5604
>                 URL: https://issues.apache.org/jira/browse/OAK-5604
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: tooling
>             Fix For: 1.7.0, 1.8, 1.6.1
>
>         Attachments: OAK-5604.patch
>
>
> Currently the {{--bin}} option expects a {{Long}} argument, as the {{LENGTH}} up to which to scan the content of binary properties. The {{--bin}} option should be simplified so that it doesn't take any arguments. Running {{check}} without the {{--bin}} flag won't scan any binary properties, while including {{--bin}} option will scan all binaries, no matter their size.
> If an argument is given with {{--bin}}, there will be a failure and a warning will be displayed.
> The message displayed at the end of the consistency check will be changed to take into account whether binary properties were traversed or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)