You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mridulm (via GitHub)" <gi...@apache.org> on 2023/04/06 16:06:37 UTC

[GitHub] [spark] mridulm commented on a diff in pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

mridulm commented on code in PR #40687:
URL: https://github.com/apache/spark/pull/40687#discussion_r1159997949


##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -1558,7 +1558,7 @@ private[spark] object JsonProtocol {
     json.extractElements.map { line =>
       val declaringClass = line.get("Declaring Class").extractString
       val methodName = line.get("Method Name").extractString
-      val fileName = line.get("File Name").extractString
+      val fileName = jsonOption(line.get("File Name")).map(_.extractString).orNull

Review Comment:
   Yes, we cannot it will be non-null.
   Also handle exception.message below ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org