You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by blackdrag <gi...@git.apache.org> on 2016/05/27 06:58:41 UTC

[GitHub] groovy pull request:

Github user blackdrag commented on the pull request:

    https://github.com/apache/groovy/commit/8c1e789864f17cc0c1fe7135397abcb15b431e93#commitcomment-17642091
  
    I think we need here one more test with `Foo.foo(42, { ['foo', 'bar'].iterator()}, "aString")`. This is to ensure the code can handle a case in which we have a fitting argument, but the argument will need to be wrapped into an array. And I think we should actually also add two more variants. One in which the last argument is null and we check that we really get null for the array in the method. And one in which the last argument is a String[] and we check the array given to the method and the array received in the method are equal. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---