You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/29 17:15:19 UTC

[GitHub] [beam] eantyshev commented on a diff in pull request #24402: [Playground] parse notebook_url example tag

eantyshev commented on code in PR #24402:
URL: https://github.com/apache/beam/pull/24402#discussion_r1035040367


##########
playground/infrastructure/datastore_client.py:
##########
@@ -83,54 +83,53 @@ def save_to_cloud_datastore(self, examples_from_rep: List[Example], sdk: Sdk, or
         examples_ids_before_updating = self._get_all_examples(sdk, origin)
 
         # loop through every example to save them to the Cloud Datastore

Review Comment:
   below is a long-lasting issue with updating big number of entities in a transaction
   really complicates testing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org