[jira] [Closed] (TAP5-2368) CSSURLRewriter should not attempt to rewrite urls in comments

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-2368.
--------------------------------------

    Resolution: Won't Fix

The work necessary to prevent the parser from recognizing URLs inside comments outweighs the benefit.

> CSSURLRewriter should not attempt to rewrite urls in comments
> -------------------------------------------------------------
>
>                 Key: TAP5-2368
>                 URL: https://issues.apache.org/jira/browse/TAP5-2368
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Felix Scheffer
>
> The following css
> {code}
> //.cboxIE6 { background:url(images/ie6/borderTopLeft.png); }
> {code}
> causes 
> {code}
> java.lang.RuntimeException
> Unable to locate asset 'classpath:com/foobar/images/ie6/borderTopLeft.png' (the file does not exist).
> 	at org.apache.tapestry5.internal.services.AssetSourceImpl.getLocalizedAssetFromResource(AssetSourceImpl.java:376)
> 	at org.apache.tapestry5.internal.services.AssetSourceImpl.getAssetInLocale(AssetSourceImpl.java:309)
> 	at org.apache.tapestry5.internal.services.AssetSourceImpl.getAsset(AssetSourceImpl.java:131)
> 	at $AssetSource_2d82890f6e9d.getAsset(Unknown Source)
> 	at org.apache.tapestry5.internal.services.assets.CSSURLRewriter.replaceURLs(CSSURLRewriter.java:163)
> 	at org.apache.tapestry5.internal.services.assets.CSSURLRewriter.access$100(CSSURLRewriter.java:45)
> 	at org.apache.tapestry5.internal.services.assets.CSSURLRewriter$1.perform(CSSURLRewriter.java:106)
> 	at org.apache.tapestry5.internal.services.assets.CSSURLRewriter$1.perform(CSSURLRewriter.java:101)
> 	at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:110)
> {code}
> even though it's commented out.



--
This message was sent by Atlassian JIRA
(v6.2#6252)