You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/12/17 04:14:52 UTC

DO NOT REPLY [Bug 48398] New: Lock fields should be final

https://issues.apache.org/bugzilla/show_bug.cgi?id=48398

           Summary: Lock fields should be final
           Product: Tomcat 6
           Version: unspecified
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


Created an attachment (id=24714)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24714)
Patch to make lock fields final

A field that is used as a lock should be final. 

The following classes have mutable locks:

org.apache.jasper.compiler.AntCompiler.javacLock

org.apache.catalina.ha.session.DeltaSession.diffLock

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48398] Lock fields should be final

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48398

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> 2010-01-06 02:51:53 GMT ---
This has been fixed in 6.0.x and will be included in 6.0.23 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48398] Lock fields should be final

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48398

--- Comment #2 from Mark Thomas <ma...@apache.org> 2009-12-30 03:15:00 GMT ---
The patches already been applied to trunk. I have proposed them for 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48398] Lock fields should be final

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48398

--- Comment #1 from Sebb <se...@apache.org> 2009-12-16 19:40:25 UTC ---
Created an attachment (id=24717)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24717)
Patch fields that should be final

Found more locks; fields could probably also be made private

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org