You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "etseidl (via GitHub)" <gi...@apache.org> on 2024/08/27 23:40:40 UTC

[PR] Pass empty vectors as min/max for all null pages when building ColumnIndex [arrow-rs]

etseidl opened a new pull request, #6316:
URL: https://github.com/apache/arrow-rs/pull/6316

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6315.
   
   # Rationale for this change
    
   Pages with all null values should write an empty array for min and max to the ColumnIndex. The current behavior is to write one `0` byte for each.
   
   # What changes are included in this PR?
   
   Pass empty vectors to `ColumnIndexBuilder::append`.
   
   # Are there any user-facing changes?
   
   No, since min/max statistics should be ignored for pages with all nulls.
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label. This change simply saves some space.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Pass empty vectors as min/max for all null pages when building ColumnIndex [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6316:
URL: https://github.com/apache/arrow-rs/pull/6316


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org