[GitHub] HyukjinKwon commented on a change in pull request #23488: [SPARK-26564] Fix wrong assertions and error messages for parameter checking

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23488: [SPARK-26564] Fix wrong assertions and error messages for parameter checking
URL: https://github.com/apache/spark/pull/23488#discussion_r247017314
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
 ##########
 @@ -413,7 +413,7 @@ private[execution] final class LongToUnsafeRowMap(val mm: TaskMemoryManager, cap
 
   private def init(): Unit = {
     if (mm != null) {
-      require(capacity < 512000000, "Cannot broadcast more than 512 millions rows")
+      require(capacity <= 512000000, "Cannot broadcast more than 512 millions rows")
 
 Review comment:
   I think the previous condition was true.
   
   https://github.com/apache/spark/blob/79c66894296840cc4a5bf6c8718ecfd2b08bcca8/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala#L80-L83
   
   negated `numRows >= 512000000` should be `capacity < 512000000`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org