You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/03/11 01:44:06 UTC

Review Request 31919: Ambari Server sync-ldap not pulling in group membership

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31919/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-10020
    https://issues.apache.org/jira/browse/AMBARI-10020


Repository: ambari


Description
-------

The filter being used for group membership is wrong.
We should be capturing and re-using DN's for the group membership lookup as part of the user import process.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java d4d3916 
  ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java b06ab09 

Diff: https://reviews.apache.org/r/31919/diff/


Testing
-------

Manual tests.

mvn clean package ...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:02 min
[INFO] Finished at: 2015-03-10T19:16:07-04:00
[INFO] Final Memory: 43M/654M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Re: Review Request 31919: Ambari Server sync-ldap not pulling in group membership

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31919/#review76065
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On March 10, 2015, 8:44 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31919/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 8:44 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-10020
>     https://issues.apache.org/jira/browse/AMBARI-10020
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The filter being used for group membership is wrong.
> We should be capturing and re-using DN's for the group membership lookup as part of the user import process.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java d4d3916 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java b06ab09 
> 
> Diff: https://reviews.apache.org/r/31919/diff/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> mvn clean package ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:02 min
> [INFO] Finished at: 2015-03-10T19:16:07-04:00
> [INFO] Final Memory: 43M/654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 31919: Ambari Server sync-ldap not pulling in group membership

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31919/#review76062
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On March 10, 2015, 8:44 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31919/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 8:44 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-10020
>     https://issues.apache.org/jira/browse/AMBARI-10020
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The filter being used for group membership is wrong.
> We should be capturing and re-using DN's for the group membership lookup as part of the user import process.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java d4d3916 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java b06ab09 
> 
> Diff: https://reviews.apache.org/r/31919/diff/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> mvn clean package ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:02 min
> [INFO] Finished at: 2015-03-10T19:16:07-04:00
> [INFO] Final Memory: 43M/654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>