You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2023/04/27 06:53:00 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue, #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package

terrymanu opened a new issue, #25356:
URL: https://github.com/apache/shardingsphere/issues/25356

   Please reference `YamlEncryptRuleConfigurationSwapperTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2058355943

   @shubham-j-sde Welcome, I just assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] boyjoy1127 commented on issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package

Posted by "boyjoy1127 (via GitHub)" <gi...@apache.org>.
boyjoy1127 commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-1585976231

   Will this issue be completed before June 15 which is the final date of version 5.4.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-1531040523

   @itsAfnanAlam Of course, I just assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] itsAfnanAlam commented on issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package

Posted by "itsAfnanAlam (via GitHub)" <gi...@apache.org>.
itsAfnanAlam commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-1531011959

   Hello! I'm interested in contributing and I noticed that issue #25356 is still open. Is it okay if I work on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-1973838940

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2059518904

   Hello, can you please help with review of tests so far. will be helpful to avoid possible mistakes in remaining cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2058331161

   Hi, Can I take this Up?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package
URL: https://github.com/apache/shardingsphere/issues/25356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package
URL: https://github.com/apache/shardingsphere/issues/25356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2067671287

   Thank you! I'd love that ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "shubham-j-sde (via GitHub)" <gi...@apache.org>.
shubham-j-sde commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2060200139

   can you plz review them now. I have kept different PR's for reqd. 8 tests to keep commit flow clean.
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-1657254307

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #25356: Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package
URL: https://github.com/apache/shardingsphere/issues/25356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add test cases for YamlShardingRuleConfigurationSwapper and other classes in same package [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #25356:
URL: https://github.com/apache/shardingsphere/issues/25356#issuecomment-2067665153

   @shubham-j-sde Thank you for doing a great job. Your code is elegant and the writing style is completely unified, which is a real pleasure to read. Welcome to contribute more!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org