[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request #3985: NPE fix for System VM's start Command

[GitBox <gi...@apache.org>]

pavanaravapalli commented on a change in pull request #3985:  NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#discussion_r396899019
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##########
 @@ -2286,7 +2286,7 @@ protected StartAnswer execute(StartCommand cmd) {
                 }
             }
 
-            if (!bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
+            if (StringUtils.isNotBlank(bootMode) && !bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
 
 Review comment:
   @sureshanaparti 
   
   here the purpose is to have bootMode initialise with default value and utilise it with uefi enabled vmprofile or normal vmprofile. however the constant which is used confusing so i have done changes and fixed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services