You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/29 21:31:59 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #6214: GEODE-9086: update docs to show support for DECRBY
nonbinaryprogrammer opened a new pull request #6214:
URL: https://github.com/apache/geode/pull/6214
this corresponds with commit 39c0abf96ae93a2a49fd0ab28ad2e96c1fa9e7a8
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #6214: GEODE-9086: update docs to show support for DECRBY
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #6214:
URL: https://github.com/apache/geode/pull/6214#discussion_r604122524
##########
File path: geode-redis/README.md
##########
@@ -159,53 +159,53 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
Review comment:
Just noticed DECR is in the unsupported column here. I guess that could be changed in a different PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #6214: GEODE-9086: update docs to show support for DECRBY
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on a change in pull request #6214:
URL: https://github.com/apache/geode/pull/6214#discussion_r604294532
##########
File path: geode-redis/README.md
##########
@@ -159,53 +159,53 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
Review comment:
we added a ticket to the backlog for double checking that the docs are correct with the state of the support/1.14 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer merged pull request #6214: GEODE-9086: update docs to show support for DECRBY
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer merged pull request #6214:
URL: https://github.com/apache/geode/pull/6214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org