You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/17 11:40:57 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #2240: fix: ignore http status code 404
mindlesscloud opened a new pull request, #2240:
URL: https://github.com/apache/incubator-devlake/pull/2240
# Summary
fix #2226
Adding an function type attribute `AfterResponse` to `helper.ApiCollectorArgs`. This function would check all the HTTP responses, if the status code is 404, it returns a predefined error `helper.ErrIgnoreAndContinue`. The rest part of the `collector` will ignore this error and skip to the next HTTP request.
### Does this close any open issues?
close #2226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2240: fix: ignore http status code 404
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2240:
URL: https://github.com/apache/incubator-devlake/pull/2240#discussion_r901267327
##########
plugins/helper/api_client.go:
##########
@@ -47,7 +47,7 @@ type ApiClient struct {
endpoint string
headers map[string]string
beforeRequest ApiClientBeforeRequest
Review Comment:
Maybe we can move ApiClientBeforeRequest to common as ApiClientAfterResponse to keep code consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2240: fix: ignore http status code 404
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2240:
URL: https://github.com/apache/incubator-devlake/pull/2240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org