You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/27 20:08:00 UTC
[jira] [Commented] (ANY23-318) ExtractionException handling in
BaseRDFExtractor.java kills entire extraction
[ https://issues.apache.org/jira/browse/ANY23-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304763#comment-16304763 ]
ASF GitHub Bot commented on ANY23-318:
--------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/52
ANY23-318 ExtractionException handling in BaseRDFExtractor.java kills entire extraction
This issue addresses https://issues.apache.org/jira/browse/ANY23-318
It also includes several improvements which will help others when debugging code. Furthermore I've corrected > Java7 code conventions whenever possible.
Apologies that this ended up a larger patch than described in the JIRA issue description however I feel it adequately addresses the issue at hand.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/any23 ANY23-318
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 4c81edde390b6b6e91566f490ca5d915ca0b0945
Author: Lewis John McGibbney <le...@...>
Date: 2017-12-27T20:06:08Z
ANY23-318 ExtractionException handling in BaseRDFExtractor.java kills entire extraction
----
> ExtractionException handling in BaseRDFExtractor.java kills entire extraction
> -----------------------------------------------------------------------------
>
> Key: ANY23-318
> URL: https://issues.apache.org/jira/browse/ANY23-318
> Project: Apache Any23
> Issue Type: Bug
> Components: core, extractors
> Affects Versions: 2.1
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Blocker
> Fix For: 2.2
>
>
> Right now the following snippet of code contained within BaseRDFExtractor.java kills entire extractions. I propose to merely log the errors and continue with the extraction.
> {code}
> } catch (RDFParseException ex) {
> - throw new ExtractionException("Error while parsing RDF document.", ex, extractionResult);
> + LOG.error("Error while parsing RDF document.", ex, extractionResult);
> }
> }
> {code}
> The parsing strictness is inherited from the underlying semargl parsers which expect perfect syntax for input data... in the 'wild' however, this unfortunately is not realistic.
> The solution is for us to log the Exception, issues, etc. and carry on with the extraction.
> Patch coming up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)