cvs commit: jakarta-turbine-maven/src/java/org/apache/maven StringTool.java

[bw...@apache.org]

bwalding    2003/02/01 18:11:24

  Added:       src/java/org/apache/maven StringTool.java
  Log:
  A place for string manipulation functions.  Removes highly complex and error prone
  jexl expressions that can be better expressed in java (and tested).
  
  Revision  Changes    Path
  1.1                  jakarta-turbine-maven/src/java/org/apache/maven/StringTool.java
  
  Index: StringTool.java
  ===================================================================
  package org.apache.maven;
  
  import java.util.Arrays;
  import java.util.List;
  
  import org.apache.commons.logging.Log;
  import org.apache.commons.logging.LogFactory;
  import org.apache.commons.logging.LogSource;
  
  /* ====================================================================
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 2002 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *    notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *    notice, this list of conditions and the following disclaimer in
   *    the documentation and/or other materials provided with the
   *    distribution.
   *
   * 3. The end-user documentation included with the redistribution,
   *    if any, must include the following acknowledgment:
   *       "This product includes software developed by the
   *        Apache Software Foundation (http://www.apache.org/)."
   *    Alternately, this acknowledgment may appear in the software itself,
   *    if and wherever such third-party acknowledgments normally appear.
   *
   * 4. The names "Apache" and "Apache Software Foundation" and
   *    "Apache Maven" must not be used to endorse or promote products
   *    derived from this software without prior written permission. For
   *    written permission, please contact apache@apache.org.
   *
   * 5. Products derived from this software may not be called "Apache",
   *    "Apache Maven", nor may "Apache" appear in their name, without
   *    prior written permission of the Apache Software Foundation.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * ====================================================================
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * <http://www.apache.org/>.
   *
   * ====================================================================
   */
  
  /**
   * @author Ben Walding
   *
   */
  public class StringTool {
      /** Log. */
      private static final Log LOG = LogFactory.getLog(StringTool.class);
  
      /**
       * Splits a string at the last delimiter. If no delimiter is found,
       * first element is the string, second element is empty string.
       * @param s the string to be split
       * @param delim the delimiter
       * @return String[] a two element array, element 0 = string up to last delim (exclusive), element 1 = string past
       * last delim (exclusive)
       */
      public List splitStringAtLastDelim(String s, String delim) {
          if (s == null) {
              String[] result = { null, null };
              return Arrays.asList(result);
          }
          
          int index = s.lastIndexOf(delim);
  
          if (index == -1) {
              String[] result = { s, "" };
              return Arrays.asList(result);
          } else {
              String[] result = { s.substring(0, index), s.substring(index + 1)};
              return Arrays.asList(result);
          }
      }
  }
  
  
  

Re: My style transgressions in cvs commit: jakarta-turbine-maven/src/java/org/apache/maven StringTool.java

[Ben Walding <be...@walding.com>]

No problems.

Now I can write twice as many lines of code per day!

Cheers,

Ben

Pete Kazmier wrote:

>Ben,
>
>We try to adhere to the Turbine-family coding conventions.  Basically,
>a file has the package statement, the license, and then the imports.
>In addition, the placement of the '{' is always on the next line by
>itself.  You can find a doc on the standards here:
>
>   http://jakarta.apache.org/turbine/common/code-standards.html
>
>Thanks,
>Pete
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: turbine-maven-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: turbine-maven-dev-help@jakarta.apache.org
>
>
>  
>

Re: cvs commit: jakarta-turbine-maven/src/java/org/apache/maven StringTool.java

[Pete Kazmier <pe...@kazmier.com>]

Ben,

We try to adhere to the Turbine-family coding conventions.  Basically,
a file has the package statement, the license, and then the imports.
In addition, the placement of the '{' is always on the next line by
itself.  You can find a doc on the standards here:

   http://jakarta.apache.org/turbine/common/code-standards.html

Thanks,
Pete