[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10347: feat: update dataset editor modal

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10347:
URL: https://github.com/apache/incubator-superset/pull/10347#discussion_r461287846



##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -0,0 +1,161 @@
+/**

Review comment:
       Not a huge deal, but let's use `git mv` to keep the history of the file attached to it! You can fix it quickly with
   ```bash
   mv superset-frontend/src/datasource/ChangeDatasourceModal.tsx /tmp
   git checkout HEAD^ superset-frontend/src/datasource/ChangeDatasourceModal.tsx
   git mv superset-frontend/src/datasource/ChangeDatasourceModal.jsx superset-frontend/src/datasource/ChangeDatasourceModal.tsx
   mv /tmp/ChangeDatasourceModal.tsx superset-frontend/src/datasource/
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org