[GitHub] [fluo-uno] arvindshmicrosoft commented on a change in pull request #236: Fix #235 skip checksum check for snapshot version

[GitBox <gi...@apache.org>]

arvindshmicrosoft commented on a change in pull request #236: Fix #235 skip checksum check for snapshot version
URL: https://github.com/apache/fluo-uno/pull/236#discussion_r348237106
 
 

 ##########
 File path: bin/impl/load-env.sh
 ##########
 @@ -139,7 +139,7 @@ if [[ -z "$ZOOKEEPER_HASH" ]]; then
   echo "ZOOKEEPER_HASH is not set. Set it for your version in 'conf/checksums' or uno.conf"
   exit 1
 fi
-if [[ -z "$ACCUMULO_HASH" ]]; then
+if [[ -z "$ACCUMULO_HASH" && "$ACCUMULO_VERSION" != *"SNAPSHOT"* ]]; then
 
 Review comment:
   I believe you don't need the double-quotes around $ACCUMULO_VERSION. On a similar note, I believe the double-quotes around SNAPSHOT are not needed as there are no embedded spaces in the "needle" string we are searching for. It is my understanding that the quotes would only be needed if there were embedded space(s) within the needle string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services