You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Eric Norman <en...@apache.org> on 2025/10/08 23:31:31 UTC
[VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
To resolve SLING-12624 <https://issues.apache.org/jira/browse/SLING-12624>
we can either bump the spotless-maven-plugin to the latest version (3.0.0)
which requires java 17 or later, or to the previous version (2.46.1) that
still works with java 11.
NOTE: sling-bundle-parent project has already
changed minimalJavaBuildVersion to 17 because Bnd 7+ requires Java 17
Also, for many of the JDK distributions, Java 11 has reached EOL status a
while ago.
So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-parent
to unify it in both places so we are ready to use third-party libraries
that now require it.
But I thought I would check if anyone still uses Java 11 and would object
to the change.
Please vote to approve this proposal:
[ ] +1 Approve the proposal
[ ] 0 Don't care
[ ] -1 Don't change, because ...
This majority vote is open for at least 72 hours.
Re: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Eric Norman <en...@apache.org>.
+1
On Wed, Oct 8, 2025 at 4:31 PM Eric Norman <en...@apache.org> wrote:
> To resolve SLING-12624 <https://issues.apache.org/jira/browse/SLING-12624>
> we can either bump the spotless-maven-plugin to the latest version (3.0.0)
> which requires java 17 or later, or to the previous version (2.46.1) that
> still works with java 11.
>
> NOTE: sling-bundle-parent project has already
> changed minimalJavaBuildVersion to 17 because Bnd 7+ requires Java 17
>
> Also, for many of the JDK distributions, Java 11 has reached EOL status a
> while ago.
>
> So my proposal is to bump the minimalJavaBuildVersion to 17 in
> sling-parent to unify it in both places so we are ready to use third-party
> libraries that now require it.
>
> But I thought I would check if anyone still uses Java 11 and would object
> to the change.
>
> Please vote to approve this proposal:
>
> [ ] +1 Approve the proposal
> [ ] 0 Don't care
> [ ] -1 Don't change, because ...
>
> This majority vote is open for at least 72 hours.
>
RE: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Stefan Seifert <st...@diva-e.com.INVALID>.
i personally would prefer to go the "clean" route with PR #58 switching the sling-parent to java 17.
as konrad noted in PR #57, using different spotless plugin versions depending will likely lead to subtle problems, depending on the JDK the build is executed upon. we should avoid this.
for the rare cases we still have a module that depends on java 11, that should stick with an older parent.
stefan
> -----Original Message-----
> From: Eric Norman <en...@apache.org>
> Sent: Wednesday, October 15, 2025 1:21 AM
> To: dev@sling.apache.org
> Subject: Re: [VOTE] Proposal to change sling-parent
> minimalJavaBuildVersion to 17
>
> Also, an alternate proposed PR is at
> https://github.com/apache/sling-parent/pull/58 that implements what I
> originally proposed if you prefer that instead.
>
> Regards,
> Eric
>
> On Tue, Oct 14, 2025 at 3:41 PM Eric Norman <en...@apache.org> wrote:
>
> > Thank you all for your feedback. Given Robert's feedback that there are
> > still some places using and testing with java 11, I have proposed a pull
> > request that should solve the issue while retaining support for java 11
> for
> > now. The 3.x version of spotless would only be used for java 17 or
> later.
> >
> > The proposed PR is at: https://github.com/apache/sling-parent/pull/57
> and
> > I have requested a review from all the people who voted here.
> >
> > Regards,
> > Eric
> >
> > On Fri, Oct 10, 2025 at 3:43 AM Robert Munteanu <ro...@apache.org>
> > wrote:
> >
> >> On Wed, 2025-10-08 at 16:31 -0700, Eric Norman wrote:
> >> > So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-
> >> > parent
> >> > to unify it in both places so we are ready to use third-party
> >> > libraries
> >> > that now require it.
> >>
> >> -0
> >>
> >> I have a module that uses sling (parent) 62 and still builds for Java
> >> 11.
> >>
> >> https://github.com/apache/sling-org-apache-sling-connection-timeout-
> agent
> >>
> >> It's a Java agent and testing on multiple JVMs is desired because it
> >> can be sensitive to low-level impl changes , see [1] for an example.
> >>
> >> But we can just delay the parent pom upgrade for that module until we
> >> decide to drop support for Java 11.
> >>
> >> If we drop Java 11 support it might be a good idea to also adjust the
> >> default build JDKs are remove Java 11, see [2] and [3].
> >>
> >> Thanks,
> >> Robert
> >>
> >> [1]:
> >>
> >> https://github.com/apache/sling-org-apache-sling-connection-timeout-
> agent/pull/9
> >> [2]:
> >>
> >> https://github.com/apache/sling-tooling-
> jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundle
> Build.groovy#L20
> >> [3]:
> >>
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor
> >>
> >
Re: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Eric Norman <en...@apache.org>.
Also, an alternate proposed PR is at
https://github.com/apache/sling-parent/pull/58 that implements what I
originally proposed if you prefer that instead.
Regards,
Eric
On Tue, Oct 14, 2025 at 3:41 PM Eric Norman <en...@apache.org> wrote:
> Thank you all for your feedback. Given Robert's feedback that there are
> still some places using and testing with java 11, I have proposed a pull
> request that should solve the issue while retaining support for java 11 for
> now. The 3.x version of spotless would only be used for java 17 or later.
>
> The proposed PR is at: https://github.com/apache/sling-parent/pull/57 and
> I have requested a review from all the people who voted here.
>
> Regards,
> Eric
>
> On Fri, Oct 10, 2025 at 3:43 AM Robert Munteanu <ro...@apache.org>
> wrote:
>
>> On Wed, 2025-10-08 at 16:31 -0700, Eric Norman wrote:
>> > So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-
>> > parent
>> > to unify it in both places so we are ready to use third-party
>> > libraries
>> > that now require it.
>>
>> -0
>>
>> I have a module that uses sling (parent) 62 and still builds for Java
>> 11.
>>
>> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent
>>
>> It's a Java agent and testing on multiple JVMs is desired because it
>> can be sensitive to low-level impl changes , see [1] for an example.
>>
>> But we can just delay the parent pom upgrade for that module until we
>> decide to drop support for Java 11.
>>
>> If we drop Java 11 support it might be a good idea to also adjust the
>> default build JDKs are remove Java 11, see [2] and [3].
>>
>> Thanks,
>> Robert
>>
>> [1]:
>>
>> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/pull/9
>> [2]:
>>
>> https://github.com/apache/sling-tooling-jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundleBuild.groovy#L20
>> [3]:
>> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor
>>
>
Re: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Eric Norman <en...@apache.org>.
Thank you all for your feedback. Given Robert's feedback that there are
still some places using and testing with java 11, I have proposed a pull
request that should solve the issue while retaining support for java 11 for
now. The 3.x version of spotless would only be used for java 17 or later.
The proposed PR is at: https://github.com/apache/sling-parent/pull/57 and I
have requested a review from all the people who voted here.
Regards,
Eric
On Fri, Oct 10, 2025 at 3:43 AM Robert Munteanu <ro...@apache.org> wrote:
> On Wed, 2025-10-08 at 16:31 -0700, Eric Norman wrote:
> > So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-
> > parent
> > to unify it in both places so we are ready to use third-party
> > libraries
> > that now require it.
>
> -0
>
> I have a module that uses sling (parent) 62 and still builds for Java
> 11.
>
> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent
>
> It's a Java agent and testing on multiple JVMs is desired because it
> can be sensitive to low-level impl changes , see [1] for an example.
>
> But we can just delay the parent pom upgrade for that module until we
> decide to drop support for Java 11.
>
> If we drop Java 11 support it might be a good idea to also adjust the
> default build JDKs are remove Java 11, see [2] and [3].
>
> Thanks,
> Robert
>
> [1]:
>
> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/pull/9
> [2]:
>
> https://github.com/apache/sling-tooling-jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundleBuild.groovy#L20
> [3]:
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor
>
Re: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2025-10-08 at 16:31 -0700, Eric Norman wrote:
> So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-
> parent
> to unify it in both places so we are ready to use third-party
> libraries
> that now require it.
-0
I have a module that uses sling (parent) 62 and still builds for Java
11.
https://github.com/apache/sling-org-apache-sling-connection-timeout-agent
It's a Java agent and testing on multiple JVMs is desired because it
can be sensitive to low-level impl changes , see [1] for an example.
But we can just delay the parent pom upgrade for that module until we
decide to drop support for Java 11.
If we drop Java 11 support it might be a good idea to also adjust the
default build JDKs are remove Java 11, see [2] and [3].
Thanks,
Robert
[1]:
https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/pull/9
[2]:
https://github.com/apache/sling-tooling-jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundleBuild.groovy#L20
[3]:
https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor
RE: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Stefan Seifert <st...@diva-e.com.INVALID>.
+1
stefan
[RESULT] [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Eric Norman <er...@gmail.com>.
Hi,
The vote has passed with the following result :
+1 (binding): Konrad Windszus, Stefan Seifert, Eric Norman
+1 (non binding): none
>
Re: [VOTE] Proposal to change sling-parent minimalJavaBuildVersion to 17
Posted by Konrad Windszus <kw...@apache.org>.
+1
Although this usually also means that we don’t execute ITs with a lower version either.
> On 9. Oct 2025, at 01:31, Eric Norman <en...@apache.org> wrote:
>
> To resolve SLING-12624 <https://issues.apache.org/jira/browse/SLING-12624>
> we can either bump the spotless-maven-plugin to the latest version (3.0.0)
> which requires java 17 or later, or to the previous version (2.46.1) that
> still works with java 11.
>
> NOTE: sling-bundle-parent project has already
> changed minimalJavaBuildVersion to 17 because Bnd 7+ requires Java 17
>
> Also, for many of the JDK distributions, Java 11 has reached EOL status a
> while ago.
>
> So my proposal is to bump the minimalJavaBuildVersion to 17 in sling-parent
> to unify it in both places so we are ready to use third-party libraries
> that now require it.
>
> But I thought I would check if anyone still uses Java 11 and would object
> to the change.
>
> Please vote to approve this proposal:
>
> [ ] +1 Approve the proposal
> [ ] 0 Don't care
> [ ] -1 Don't change, because ...
>
> This majority vote is open for at least 72 hours.