You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/05 07:41:19 UTC
[GitHub] [dubbo-go] cadeeper opened a new pull request #850: fix bug: pathMap cache need to delete after node removed
cadeeper opened a new pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850
as the title mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #850: fix bug: pathMap cache need to delete after node removed
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cadeeper commented on pull request #850: fix bug: pathMap cache need to delete after node removed
Posted by GitBox <gi...@apache.org>.
cadeeper commented on pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850#issuecomment-722788780
> What will happen if it is not deleted?
node add event won't trigger when the same provider node unregister and regiester again. it will continue on : @zkPath %s has already been listened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #850: fix bug: pathMap cache need to delete after node removed
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850#discussion_r518527414
##########
File path: remoting/zookeeper/listener.go
##########
@@ -301,6 +301,9 @@ func (l *ZkEventListener) listenDirEvent(conf *common.URL, zkPath string, listen
go func(zkPath string, listener remoting.DataListener) {
if l.listenServiceNodeEvent(zkPath) {
listener.DataChange(remoting.Event{Path: zkPath, Action: remoting.EventTypeDel})
+ l.pathMapLock.Lock()
+ delete(l.pathMap, zkPath)
+ l.pathMapLock.Unlock()
Review comment:
plg using defer here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cadeeper commented on a change in pull request #850: fix bug: pathMap cache need to delete after node removed
Posted by GitBox <gi...@apache.org>.
cadeeper commented on a change in pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850#discussion_r518543236
##########
File path: remoting/zookeeper/listener.go
##########
@@ -301,6 +301,9 @@ func (l *ZkEventListener) listenDirEvent(conf *common.URL, zkPath string, listen
go func(zkPath string, listener remoting.DataListener) {
if l.listenServiceNodeEvent(zkPath) {
listener.DataChange(remoting.Event{Path: zkPath, Action: remoting.EventTypeDel})
+ l.pathMapLock.Lock()
+ delete(l.pathMap, zkPath)
+ l.pathMapLock.Unlock()
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #850: fix bug: pathMap cache need to delete after node removed
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #850:
URL: https://github.com/apache/dubbo-go/pull/850#issuecomment-722206143
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=h1) Report
> Merging [#850](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/22107248cc73da8e01f540165dc4025d5234a738?el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #850 +/- ##
===========================================
- Coverage 60.14% 60.03% -0.11%
===========================================
Files 260 260
Lines 12770 12773 +3
===========================================
- Hits 7680 7668 -12
- Misses 4134 4149 +15
Partials 956 956
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `45.45% <0.00%> (-0.70%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `67.30% <0.00%> (-2.89%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `49.79% <0.00%> (-1.64%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/850/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=footer). Last update [2210724...ad2d6ed](https://codecov.io/gh/apache/dubbo-go/pull/850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org