[GitHub] [superset] mistercrunch commented on a diff in pull request #24348: feat: add a tooltip to clarify metric_name in the DatasetEditor

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on code in PR #24348:
URL: https://github.com/apache/superset/pull/24348#discussion_r1227356915


##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -311,6 +320,25 @@ export default class CRUDCollection extends React.PureComponent<
     return <Icons.Sort onClick={this.sortColumn(col, 1)} />;
   }
 
+  renderTH(col: string, sortColumns: Array<string>) {
+    const tooltip = this.getTooltip(col);
+    return (
+      <th key={col} className="no-wrap">

Review Comment:
   no-wrap is the real mvp I snuck into this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org