[GitHub] [tvm] tqchen commented on a diff in pull request #14665: [Unity] Add MultiSpan and attach it to CallNode produced by FuseOps

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen commented on code in PR #14665:
URL: https://github.com/apache/tvm/pull/14665#discussion_r1171376249


##########
include/tvm/ir/source_map.h:
##########
@@ -127,6 +127,31 @@ class Span : public ObjectRef {
   TVM_DEFINE_OBJECT_REF_METHODS(Span, ObjectRef, SpanNode);
 };
 
+class MultiSpanNode : public SpanNode {
+ public:
+  Map<Span, ObjectRef> spans;

Review Comment:
   I am not sure if it should be a dictionary, the span should be self-contained ideally and can be detached, so at best it should be an Array of Span to show the original tracking history



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org