You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/14 07:31:20 UTC

[GitHub] [iotdb] flashzxi opened a new pull request, #5521: [IOTDB-2888] Unary expression bug fix

flashzxi opened a new pull request, #5521:
URL: https://github.com/apache/iotdb/pull/5521

   When you select unary expression with a constant expression, it will throw 
   ```java.lang.UnsupportedOperationException```
   
   for example
   ```sql
   select - 1 + s1 from root.test;
   ```
   
   now fixed this bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on pull request #5521: [IOTDB-2888] Unable to select an unary expression followed by a constant expression

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on PR #5521:
URL: https://github.com/apache/iotdb/pull/5521#issuecomment-1099213484

   Please notice the spotless issue :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] flashzxi closed pull request #5521: [IOTDB-2888] Unary expression bug fix

Posted by GitBox <gi...@apache.org>.
flashzxi closed pull request #5521: [IOTDB-2888] Unary expression bug fix
URL: https://github.com/apache/iotdb/pull/5521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #5521: [IOTDB-2888] Unable to select an unary expression followed by a constant expression

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged PR #5521:
URL: https://github.com/apache/iotdb/pull/5521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #5521: [IOTDB-2888] Unary expression bug fix

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on code in PR #5521:
URL: https://github.com/apache/iotdb/pull/5521#discussion_r850435376


##########
server/src/main/java/org/apache/iotdb/db/query/expression/binary/BinaryExpression.java:
##########
@@ -50,6 +50,7 @@
 
 public abstract class BinaryExpression extends Expression {
 
+  protected static Map<String, Integer> priority;

Review Comment:
   Remove it since it is useless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org