You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2012/04/11 02:45:26 UTC
[jira] [Created] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Use ToolRunner.confirmPrompt in NameNode
----------------------------------------
Key: HDFS-3249
URL: https://issues.apache.org/jira/browse/HDFS-3249
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 2.0.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Trivial
One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251346#comment-13251346 ]
Hudson commented on HDFS-3249:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2125 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2125/])
HDFS-3249. Use ToolRunner.confirmPrompt in NameNode. Contributed by Todd Lipcon. (Revision 1324564)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324564
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3249:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to branch-2 and trunk. No tests because this is just a trivial code move. Thanks for the review.
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3249:
------------------------------
Status: Patch Available (was: Open)
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251253#comment-13251253 ]
Hadoop QA commented on HDFS-3249:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522182/hdfs-3249.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2246//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2246//console
This message is automatically generated.
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251215#comment-13251215 ]
Aaron T. Myers commented on HDFS-3249:
--------------------------------------
+1 pending Jenkins.
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-3249:
------------------------------
Attachment: hdfs-3249.txt
trivial patch
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251367#comment-13251367 ]
Hudson commented on HDFS-3249:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2064 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2064/])
HDFS-3249. Use ToolRunner.confirmPrompt in NameNode. Contributed by Todd Lipcon. (Revision 1324564)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324564
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251543#comment-13251543 ]
Hudson commented on HDFS-3249:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1011 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/])
HDFS-3249. Use ToolRunner.confirmPrompt in NameNode. Contributed by Todd Lipcon. (Revision 1324564)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324564
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251594#comment-13251594 ]
Hudson commented on HDFS-3249:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1046 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/])
HDFS-3249. Use ToolRunner.confirmPrompt in NameNode. Contributed by Todd Lipcon. (Revision 1324564)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324564
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3249) Use ToolRunner.confirmPrompt in
NameNode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251347#comment-13251347 ]
Hudson commented on HDFS-3249:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2051 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2051/])
HDFS-3249. Use ToolRunner.confirmPrompt in NameNode. Contributed by Todd Lipcon. (Revision 1324564)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324564
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part of ToolRunner, so it's available as utility code. We should now use this utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira