[GitHub] [flink] zhijiangW opened a new pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment

[GitBox <gi...@apache.org>]

zhijiangW opened a new pull request #8095: [FLINK-12078][network] Abstract TaskEventPublisher interface for simplifying NetworkEnvironment
URL: https://github.com/apache/flink/pull/8095
 
 
   ## What is the purpose of the change
   
   *Currently `TaskEventDispatcher` is maintained in `NetworkEnvironment` for register/unregister partition and used for `NettyConnectionManager`. In order for further decoupling `Task` with `NetworkEnvironment`, we introduce `TaskEventPublisher` interface for providing publish method only. Then the `NetworkEnvironment` could maintain `TaskEventPublisher` and the register/unregister would be removed outside to be handled by `Task` directly.*
   
   *To do so, the `NetworkEnvironment#unregisterTask` would be removed finally and the `partition/gate#close` could be instead.*
   
   ## Brief change log
   
     - *Introduce the `TaskEventPublisher` interface*
     - *Make `TaskEventDispatcher` implements `TaskEventPublisher`*
     - *Make `TaskEventDispatcher` register/unregister partition outside of `NetworkEnvironment`*
     - *Make `TaskEventDispatcher` as basic service in `TaskManagerServices`*
     - *Reference `TaskEventPublisher` instead of `TaskEventDispatcher` in related classes*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *TaskEventDispatcherTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services