You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Pavel Yaskevich (JIRA)" <ji...@apache.org> on 2011/02/14 16:06:57 UTC
[jira] Created: (CASSANDRA-2160) Add "join" command to the nodetool
with one unnecessary parameter
Add "join" command to the nodetool with one unnecessary parameter <token>
-------------------------------------------------------------------------
Key: CASSANDRA-2160
URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
Project: Cassandra
Issue Type: Improvement
Components: Contrib
Affects Versions: 0.7.0
Reporter: Pavel Yaskevich
Assignee: Pavel Yaskevich
Priority: Minor
Fix For: 0.7.2
Nodetool should be able to make current node join/re-join a ring. If token was not specified Bootstrapper.getBalancedToken should be used.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2160:
--------------------------------------
Reviewer: slebresne (was: jbellis)
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000198#comment-13000198 ]
Pavel Yaskevich commented on CASSANDRA-2160:
--------------------------------------------
This helps you to return node to the ring after decommission or if it haven't joined the ring at startup without restarting application.
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2160:
----------------------------------------
Fix Version/s: (was: 0.7.2)
0.7.3
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000341#comment-13000341 ]
Sylvain Lebresne commented on CASSANDRA-2160:
---------------------------------------------
+1
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000392#comment-13000392 ]
Hudson commented on CASSANDRA-2160:
-----------------------------------
Integrated in Cassandra-0.7 #330 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/330/])
Add "join" command to nodetool
Patch by Pavel Yaskevich, reviewed by Sylvain Lebresne for
CASSANDRA-2160
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-rebased.patch, CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000221#comment-13000221 ]
Sylvain Lebresne commented on CASSANDRA-2160:
---------------------------------------------
Minor nitpick:
- There is a lot of whitespace diffs
- Is there a reason for using -1 as an exit code in System.exit() ? I'm not an exit code expert but I'd fear a negative one would confuse the hell out of some shells.
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-v2.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000374#comment-13000374 ]
Pavel Yaskevich commented on CASSANDRA-2160:
--------------------------------------------
This is exactly rebase after CASSANDRA-2219
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-rebased.patch, CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2160:
---------------------------------------
Attachment: CASSANDRA-2160-v2.patch
Now nodetool uses joinRing() method to join the ring if Cassandra was started with -Djoin_ring=false
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-v2.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2160:
---------------------------------------
Attachment: CASSANDRA-2160-rebased.patch
Rebased with the latest committed changes for nodetool
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-rebased.patch, CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2160:
---------------------------------------
Attachment: CASSANDRA-2160.patch
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000196#comment-13000196 ]
Sylvain Lebresne commented on CASSANDRA-2160:
---------------------------------------------
Not sure I understand this one.
We already have enable/disable thrift/gossip to unjoin/rejoin the ring. Is the goal here different ?
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000209#comment-13000209 ]
Sylvain Lebresne commented on CASSANDRA-2160:
---------------------------------------------
bq. This helps you to return node to the ring after decommission or if it haven't joined the ring at startup without restarting application.
Ok for joining the ring if -Djoin_ring=false was used at startup. But then SP.joinRing() should be called. This is exposed through JMX but not nodetool and I do agree that it should.
As for rejoining after decommission, I don't see the point. You're not supposed to decommission a node for no reason. I'm not confortable adding code that isn't clearly useful.
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2160:
---------------------------------------
Description: Nodetool should be able to make current node join/re-join a ring. (was: Nodetool should be able to make current node join/re-join a ring. If token was not specified Bootstrapper.getBalancedToken should be used.)
Summary: Add "join" command to the nodetool (was: Add "join" command to the nodetool with one unnecessary parameter <token>)
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2160) Add "join" command to the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2160:
---------------------------------------
Attachment: CASSANDRA-2160-v3.patch
System.exit code changed to 1, all whitespace diffs all cleaned.
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (CASSANDRA-2160) Add "join" command to
the nodetool
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000228#comment-13000228 ]
Pavel Yaskevich edited comment on CASSANDRA-2160 at 2/28/11 11:15 AM:
----------------------------------------------------------------------
System.exit code changed to 1, all whitespace diffs are cleaned.
was (Author: xedin):
System.exit code changed to 1, all whitespace diffs all cleaned.
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2160) Add "join" command to the
nodetool
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000372#comment-13000372 ]
Brandon Williams commented on CASSANDRA-2160:
---------------------------------------------
Looks like it needs one more rebase after CASSANDRA-2219 :(
> Add "join" command to the nodetool
> ----------------------------------
>
> Key: CASSANDRA-2160
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2160
> Project: Cassandra
> Issue Type: Improvement
> Components: Contrib
> Affects Versions: 0.7.0
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2160-rebased.patch, CASSANDRA-2160-v2.patch, CASSANDRA-2160-v3.patch, CASSANDRA-2160.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Nodetool should be able to make current node join/re-join a ring.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira