You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/13 11:56:55 UTC

[GitHub] [shardingsphere] Lucas-307 opened a new pull request #8155: Extract scaling job service.

Lucas-307 opened a new pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155


   Changes proposed in this pull request:
   - Extract scaling job service.
   - Distributed scaling job service impl.
   - Standalone scaling job service impl.
   - Fixes #8130.
   - Fixes javadoc exception.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 removed a comment on pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
Lucas-307 removed a comment on pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155#issuecomment-727695877


   please wait for ci.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 commented on pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155#issuecomment-727695877


   please wait for ci.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155#issuecomment-727708609


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=h1) Report
   > Merging [#8155](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=desc) (bc7ad5a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/eec6c105479b6de4f3b106030c4307b4a06419c9?el=desc) (eec6c10) will **increase** coverage by `1.63%`.
   > The diff coverage is `89.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8155/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8155      +/-   ##
   ============================================
   + Coverage     73.57%   75.20%   +1.63%     
   - Complexity      532      575      +43     
   ============================================
     Files          1446     1453       +7     
     Lines         23027    23190     +163     
     Branches       4141     4154      +13     
   ============================================
   + Hits          16941    17439     +498     
   + Misses         4958     4610     -348     
   - Partials       1128     1141      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ing/core/check/AbstractDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jaGVjay9BYnN0cmFjdERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `80.00% <0.00%> (+80.00%)` | `7.00 <0.00> (+7.00)` | |
   | [...gsphere/scaling/core/config/RuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `71.42% <ø> (+14.28%)` | `1.00 <0.00> (+1.00)` | |
   | [...phere/scaling/core/config/ServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvU2VydmVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VNYW5hZ2VyLmphdmE=) | `86.48% <0.00%> (+48.64%)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VXcmFwcGVyLmphdmE=) | `19.04% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/execute/executor/importer/DataRecordMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0RhdGFSZWNvcmRNZXJnZXIuamF2YQ==) | `95.18% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../scaling/core/job/position/PrimaryKeyPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vUHJpbWFyeUtleVBvc2l0aW9uLmphdmE=) | `33.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...scaling/core/service/ScalingJobServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL1NjYWxpbmdKb2JTZXJ2aWNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ere/scaling/mysql/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMRGF0YUNvbnNpc3RlbmN5Q2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ingsphere/scaling/mysql/binlog/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2JpbmxvZy9CaW5sb2dQb3NpdGlvbi5qYXZh) | `88.88% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [67 more](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=footer). Last update [eec6c10...bc7ad5a](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155#issuecomment-727708609


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=h1) Report
   > Merging [#8155](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=desc) (bc7ad5a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/eec6c105479b6de4f3b106030c4307b4a06419c9?el=desc) (eec6c10) will **increase** coverage by `1.63%`.
   > The diff coverage is `89.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8155/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8155      +/-   ##
   ============================================
   + Coverage     73.57%   75.20%   +1.63%     
   - Complexity      532      575      +43     
   ============================================
     Files          1446     1453       +7     
     Lines         23027    23190     +163     
     Branches       4141     4154      +13     
   ============================================
   + Hits          16941    17439     +498     
   + Misses         4958     4610     -348     
   - Partials       1128     1141      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ing/core/check/AbstractDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jaGVjay9BYnN0cmFjdERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `80.00% <0.00%> (+80.00%)` | `7.00 <0.00> (+7.00)` | |
   | [...gsphere/scaling/core/config/RuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `71.42% <ø> (+14.28%)` | `1.00 <0.00> (+1.00)` | |
   | [...phere/scaling/core/config/ServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvU2VydmVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VNYW5hZ2VyLmphdmE=) | `86.48% <0.00%> (+48.64%)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VXcmFwcGVyLmphdmE=) | `19.04% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/execute/executor/importer/DataRecordMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0RhdGFSZWNvcmRNZXJnZXIuamF2YQ==) | `95.18% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../scaling/core/job/position/PrimaryKeyPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vUHJpbWFyeUtleVBvc2l0aW9uLmphdmE=) | `33.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...scaling/core/service/ScalingJobServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL1NjYWxpbmdKb2JTZXJ2aWNlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ere/scaling/mysql/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL015U1FMRGF0YUNvbnNpc3RlbmN5Q2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ingsphere/scaling/mysql/binlog/BinlogPosition.java](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2JpbmxvZy9CaW5sb2dQb3NpdGlvbi5qYXZh) | `88.88% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [67 more](https://codecov.io/gh/apache/shardingsphere/pull/8155/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=footer). Last update [eec6c10...bc7ad5a](https://codecov.io/gh/apache/shardingsphere/pull/8155?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] avalon5666 commented on pull request #8155: Extract scaling job service.

Posted by GitBox <gi...@apache.org>.
avalon5666 commented on pull request #8155:
URL: https://github.com/apache/shardingsphere/pull/8155#issuecomment-727576934


   ci failed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org