You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by tf...@apache.org on 2014/10/26 12:29:11 UTC
svn commit: r1634300 -
/db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java
Author: tfischer
Date: Sun Oct 26 11:29:11 2014
New Revision: 1634300
URL: http://svn.apache.org/r1634300
Log:
Use final where possible
Modified:
db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java
Modified: db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java
URL: http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java?rev=1634300&r1=1634299&r2=1634300&view=diff
==============================================================================
--- db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java (original)
+++ db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/criteria/FromElement.java Sun Oct 26 11:29:11 2014
@@ -62,7 +62,7 @@ public class FromElement implements Seri
* table_1<br />
* table_1 alias_for_table_1
*/
- public FromElement(String tableName)
+ public FromElement(final String tableName)
{
this(tableName, null, null, null);
}
@@ -84,9 +84,9 @@ public class FromElement implements Seri
* whereClause instead)
*/
public FromElement(
- String fromExpression,
- JoinType joinType,
- String joinCondition)
+ final String fromExpression,
+ final JoinType joinType,
+ final String joinCondition)
{
this(fromExpression, joinType, joinCondition, null);
}
@@ -110,10 +110,10 @@ public class FromElement implements Seri
* which might occur in the fromExpression, may be null.
*/
public FromElement(
- String fromExpression,
- JoinType joinType,
- String joinCondition,
- List<Object> preparedStatementReplacements)
+ final String fromExpression,
+ final JoinType joinType,
+ final String joinCondition,
+ final List<Object> preparedStatementReplacements)
{
this.fromExpression = fromExpression;
this.joinType = joinType;
@@ -139,13 +139,13 @@ public class FromElement implements Seri
* e.g. table_a.id = table_b.a_id, not null.
*/
public FromElement(
- String fromExpression,
- JoinType joinType,
- PreparedStatementPart joinCondition)
+ final String fromExpression,
+ final JoinType joinType,
+ final PreparedStatementPart joinCondition)
{
this(fromExpression,
joinType,
- joinCondition.getSql().toString(),
+ joinCondition.getSqlAsString(),
joinCondition.getPreparedStatementReplacements());
}
@@ -235,7 +235,7 @@ public class FromElement implements Seri
@Override
- public boolean equals(Object obj)
+ public boolean equals(final Object obj)
{
if (this == obj)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org