You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by sebastianrothbucher <gi...@git.apache.org> on 2014/07/17 23:22:52 UTC
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
GitHub user sebastianrothbucher opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/3
2160 fix csp for Fauxton dev mode
The ace editor uses data: to load images - so we have to allow for that. The same would apply when serving fauxton out of CouchDB w/out node.js. This PR fixes the node.js-based dev mode (grunt dev)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sebastianrothbucher/couchdb-fauxton 2160-fix-csp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 99665a15ac3a1e56259eb7445b9b2e505ac361fc
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-10T18:29:50Z
Fauxton: Fix scrollbar from sidebar on collapsed state in Chrome
With a collapsed sidebar, in Chrome, the scrollbar was always
visible, even if the z-index of the dashboard was higher.
commit 599a4dd9a3d49525f341a3caf5e89de4a9c01b1e
Author: sebastianrothbucher <se...@googlemail.com>
Date: 2014-07-17T20:58:43Z
fix CSP for Fauxton dev mode
commit f5f2cea9c5079bf5d708ec89b10eda9005019491
Author: sebastianrothbucher <se...@googlemail.com>
Date: 2014-07-17T21:20:14Z
Merge branch 'master' of https://github.com/apache/couchdb-fauxton into 2160-fix-csp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49368291
needs squashing before merge (at least the merge commit).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton
dev mode
Posted by Sebastian Rothbucher <se...@googlemail.com>.
I give up - how would I change w/out closing? Thanks a lot!
On Fri, Jul 18, 2014 at 12:22 AM, sebastianrothbucher <gi...@git.apache.org>
wrote:
> Github user sebastianrothbucher commented on the pull request:
>
> https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49374550
>
> took the KISS solution now 4 the one-liner but thanks!
>
>
> On Thu, Jul 17, 2014 at 11:49 PM, Robert Newson <
> notifications@github.com>
> wrote:
>
> > closed why? You can adjust all those without closing. :)
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49371510>.
> >
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49374550
took the KISS solution now 4 the one-liner but thanks!
On Thu, Jul 17, 2014 at 11:49 PM, Robert Newson <no...@github.com>
wrote:
> closed why? You can adjust all those without closing. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49371510>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49371510
closed why? You can adjust all those without closing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2160 fix csp for Fauxton dev mode
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/3#issuecomment-49368376
ooh, and to 'master' please, not import-master. we'll be deleting those branches soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---