You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2008/09/23 10:48:47 UTC
[jira] Created: (SLING-672) Parameter name decoding fails
Parameter name decoding fails
-----------------------------
Key: SLING-672
URL: https://issues.apache.org/jira/browse/SLING-672
Project: Sling
Issue Type: Bug
Components: Engine
Affects Versions: Engine 2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: Engine 2.0.4
Currently part of request parameter re-ecoding is the re-encoding of the request parameter names. This is done in the Util.fixEncoding method. Parameter name re-encoding is done using the URLDecoder.decode method with the idea, that the name is still URL-encoded.
This does not seem to be the case -- in fact a test shows, that (at least FF 2) sends request parameter names not URL-encoded but encoded with the form character set.
So the correct way probably (this is real trial and error stuff, unfortunately) is to not do URL decoding but to just re-encode the parameter name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-672) Parameter name decoding fails
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-672.
-------------------------------------
Resolution: Fixed
Implemented correct re-encoding in Rev. 698147.
> Parameter name decoding fails
> -----------------------------
>
> Key: SLING-672
> URL: https://issues.apache.org/jira/browse/SLING-672
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.0.2
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Engine 2.0.4
>
>
> Currently part of request parameter re-ecoding is the re-encoding of the request parameter names. This is done in the Util.fixEncoding method. Parameter name re-encoding is done using the URLDecoder.decode method with the idea, that the name is still URL-encoded.
> This does not seem to be the case -- in fact a test shows, that (at least FF 2) sends request parameter names not URL-encoded but encoded with the form character set.
> So the correct way probably (this is real trial and error stuff, unfortunately) is to not do URL decoding but to just re-encode the parameter name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-672) Parameter name decoding fails
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-672.
-----------------------------------
Tested this fix with two servlet containers (Jetty and Day Servlet Engine) as well as with Firefox 2 on Linux and Windows and Firefox 3 (Windows), IE6 (Windows) and Safari (Windows).
Provided the data is submitted as a multipart/form-data POST request, the form data is correctly encoded and may be used for further perusal.
Considering this issue fix.
> Parameter name decoding fails
> -----------------------------
>
> Key: SLING-672
> URL: https://issues.apache.org/jira/browse/SLING-672
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.0.2
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Engine 2.0.4
>
>
> Currently part of request parameter re-ecoding is the re-encoding of the request parameter names. This is done in the Util.fixEncoding method. Parameter name re-encoding is done using the URLDecoder.decode method with the idea, that the name is still URL-encoded.
> This does not seem to be the case -- in fact a test shows, that (at least FF 2) sends request parameter names not URL-encoded but encoded with the form character set.
> So the correct way probably (this is real trial and error stuff, unfortunately) is to not do URL decoding but to just re-encode the parameter name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.