You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2018/03/23 22:39:27 UTC

Review Request 66264: HIVE-19027

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66264/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-19027
    https://issues.apache.org/jira/browse/HIVE-19027


Repository: hive-git


Description
-------

HIVE-19027

Includes HIVE-18825 and HIVE-19017, which are blockers for this patch.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194708ffacabfdb69d6af7d6193dcf156 
  metastore/scripts/upgrade/derby/048-HIVE-14498.derby.sql e28d002ad654ce0c7c3cf4a7d77601f97c87f088 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 2b1dd5bf7ff3ea0a0293eb5d1fb5e3832f70b820 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 3444439ce4f7ee1dfd32897df8ab87b3c9cbbe5c 
  metastore/scripts/upgrade/mssql/033-HIVE-14498.mssql.sql cb41b99abdbedae06311629590d8cd9f0e210d97 
  metastore/scripts/upgrade/mysql/048-HIVE-14498.mysql.sql 1a791a6d00ffcec5c55e77c36fc71776e9809f1f 
  metastore/scripts/upgrade/oracle/048-HIVE-14498.oracle.sql 9c3e3cc6f6a892ea492e55d3c6922df598d513a9 
  metastore/scripts/upgrade/postgres/047-HIVE-14498.postgres.sql 8d1c5b2d7cf4eed4904902f10ff133b2363c109d 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 75f928b69d3d7b206564216d24be450848a1fe8a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4eafcde7fb397a1dbf731aa4a9c48f835688ec27 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewTask.java de120afbbcd02dc23dff163c14fd7c8fba25db0c 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java da690b4aa45fcd64ae2e3bfb573de5af55f57e16 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java ba0d56ae37761091876db52984302d2f7fd34d6f 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java efc0cfe94089fe1987e5c1a9740596d5af2a2993 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 7206e296fdde1a100ebfbd6fbd097b8b18c3a5e3 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp b7a3b929bee0e969a261cc5d2b6c0e4b43cb852c 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 8d9ad254a333fc037baef89f4ed1cd075868e876 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 05a7a29fcc46b26786a90ee41944009db9bc1b0b 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 620d6ef6bac988101927f1abc59a4b87df3c3f87 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreationMetadata.java ed89b2e9386ee96d55cac005500d147fc437be13 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FindSchemasByColsResp.java 01bc32d70b373f23c88a749d4ad35020f2cf91ce 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Materialization.java dc6dc0d560b56e9847c2ed10009b7d0a7f2cab1c 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SchemaVersion.java fb0be40fba434435be7ce2ac183f4d75cbbf4011 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 8c5ceafb251997e102ee3e828e8adf8e245de9b2 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java 2fc0e00d6c45706bd25511ad92fae714e25527ea 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java 0ddb2b2dff5bebec1891bc957916f1179dbad693 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java 93fa2b7ee92dfafa44b5f521a00f51b8a9e355fd 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java 97d33c1da4a20eb409e623c1fabfb68c175a502d 
  standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php efe693a65e0eac03bf5cb6e33510ce7e58a4a3ce 
  standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 6e3ec622ccc089b2f00f836c5bed109b6f28b66b 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a8e83863f7065dac53d430d248fba8c2ebc41ede 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 30214d8df82a0a5bf3d3f9131b7a9c85e8c866f5 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 486f0612b9d778445826405201813dfd89cbf924 
  standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb dd7467c50316203e346bf763ed5633a294d3cb24 
  standalone-metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e6787c1e0249a91a5dc30784d46035af77a75ea7 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 84fac2dfa4f29c1cd67d6a06e1f31e6aad016c75 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 0e561f82ff28242f1ec62dd0b141b6707506d461 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java f1d50666573d9feba4b348f0dda88947fecba99d 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationInvalidationInfo.java 3d774071c2ff00e892540364a7ec63e49b8089df 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java cc168a913bea341bf9efd04a8e3cc28096dd3118 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java 1636d48d2c7dd21ea25dd3d670103ee3c618df38 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 88d88ed4dfbdab436698f470b69750ce5dc9bc30 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java 9f822564bdfdce16a262638d006b8e0c714405e9 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCreationMetadata.java 1133cb12427fe16e4a2900f92e98140dcd34fc57 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java e453e5a7d2ec75a962194ae95a866aafee6e1b47 
  standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql de9688d1111a4b3a157e1df9d1d88097d0262b7a 
  standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql 68237ec1fa7bbc942ef7122107923e30dd04c490 
  standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql 3e2db2ab0013b467ebcac63f8b7a0b75a6b0ffc5 
  standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql 09c40ada49c7208c2f634197232c31dfc601c5b2 
  standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql 69317b0e09b3fa907770c7bd209a54f2de35c2c2 
  standalone-metastore/src/main/thrift/hive_metastore.thrift ef63eabe44409af750cc13cc93d58d247049fb13 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMaterializationsCacheCleaner.java 6d3f68c0f0723dcdf15ee80de91a6c5a18c202ef 
  storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java PRE-CREATION 
  storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66264/diff/1/


Testing
-------


Thanks,

Jesús Camacho Rodríguez


Re: Review Request 66264: HIVE-19027

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66264/
-----------------------------------------------------------

(Updated March 23, 2018, 10:47 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Moving conf to minutes instead of seconds.


Bugs: HIVE-19027
    https://issues.apache.org/jira/browse/HIVE-19027


Repository: hive-git


Description
-------

HIVE-19027

Includes HIVE-18825 and HIVE-19017, which are blockers for this patch.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194708ffacabfdb69d6af7d6193dcf156 
  metastore/scripts/upgrade/derby/048-HIVE-14498.derby.sql e28d002ad654ce0c7c3cf4a7d77601f97c87f088 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 2b1dd5bf7ff3ea0a0293eb5d1fb5e3832f70b820 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 3444439ce4f7ee1dfd32897df8ab87b3c9cbbe5c 
  metastore/scripts/upgrade/mssql/033-HIVE-14498.mssql.sql cb41b99abdbedae06311629590d8cd9f0e210d97 
  metastore/scripts/upgrade/mysql/048-HIVE-14498.mysql.sql 1a791a6d00ffcec5c55e77c36fc71776e9809f1f 
  metastore/scripts/upgrade/oracle/048-HIVE-14498.oracle.sql 9c3e3cc6f6a892ea492e55d3c6922df598d513a9 
  metastore/scripts/upgrade/postgres/047-HIVE-14498.postgres.sql 8d1c5b2d7cf4eed4904902f10ff133b2363c109d 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 75f928b69d3d7b206564216d24be450848a1fe8a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4eafcde7fb397a1dbf731aa4a9c48f835688ec27 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewTask.java de120afbbcd02dc23dff163c14fd7c8fba25db0c 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java da690b4aa45fcd64ae2e3bfb573de5af55f57e16 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java ba0d56ae37761091876db52984302d2f7fd34d6f 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java efc0cfe94089fe1987e5c1a9740596d5af2a2993 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q 0755d39f1970876369cb5b7cc5e15c8e02f95698 
  ql/src/test/results/clientpositive/materialized_view_create_rewrite_time_window.q.out bfbac3f3492fdd15b55475cd423cf262793cff84 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 7206e296fdde1a100ebfbd6fbd097b8b18c3a5e3 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp b7a3b929bee0e969a261cc5d2b6c0e4b43cb852c 
  standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 8d9ad254a333fc037baef89f4ed1cd075868e876 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 05a7a29fcc46b26786a90ee41944009db9bc1b0b 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 620d6ef6bac988101927f1abc59a4b87df3c3f87 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreationMetadata.java ed89b2e9386ee96d55cac005500d147fc437be13 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FindSchemasByColsResp.java 01bc32d70b373f23c88a749d4ad35020f2cf91ce 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Materialization.java dc6dc0d560b56e9847c2ed10009b7d0a7f2cab1c 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SchemaVersion.java fb0be40fba434435be7ce2ac183f4d75cbbf4011 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 8c5ceafb251997e102ee3e828e8adf8e245de9b2 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java 2fc0e00d6c45706bd25511ad92fae714e25527ea 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java 0ddb2b2dff5bebec1891bc957916f1179dbad693 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java 93fa2b7ee92dfafa44b5f521a00f51b8a9e355fd 
  standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java 97d33c1da4a20eb409e623c1fabfb68c175a502d 
  standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php efe693a65e0eac03bf5cb6e33510ce7e58a4a3ce 
  standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 6e3ec622ccc089b2f00f836c5bed109b6f28b66b 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a8e83863f7065dac53d430d248fba8c2ebc41ede 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 30214d8df82a0a5bf3d3f9131b7a9c85e8c866f5 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 486f0612b9d778445826405201813dfd89cbf924 
  standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb dd7467c50316203e346bf763ed5633a294d3cb24 
  standalone-metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e6787c1e0249a91a5dc30784d46035af77a75ea7 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 84fac2dfa4f29c1cd67d6a06e1f31e6aad016c75 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 0e561f82ff28242f1ec62dd0b141b6707506d461 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java f1d50666573d9feba4b348f0dda88947fecba99d 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationInvalidationInfo.java 3d774071c2ff00e892540364a7ec63e49b8089df 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java cc168a913bea341bf9efd04a8e3cc28096dd3118 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java 1636d48d2c7dd21ea25dd3d670103ee3c618df38 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 88d88ed4dfbdab436698f470b69750ce5dc9bc30 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java 9f822564bdfdce16a262638d006b8e0c714405e9 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCreationMetadata.java 1133cb12427fe16e4a2900f92e98140dcd34fc57 
  standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java e453e5a7d2ec75a962194ae95a866aafee6e1b47 
  standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql de9688d1111a4b3a157e1df9d1d88097d0262b7a 
  standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql 68237ec1fa7bbc942ef7122107923e30dd04c490 
  standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql 3e2db2ab0013b467ebcac63f8b7a0b75a6b0ffc5 
  standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql 09c40ada49c7208c2f634197232c31dfc601c5b2 
  standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql 69317b0e09b3fa907770c7bd209a54f2de35c2c2 
  standalone-metastore/src/main/thrift/hive_metastore.thrift ef63eabe44409af750cc13cc93d58d247049fb13 
  standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMaterializationsCacheCleaner.java 6d3f68c0f0723dcdf15ee80de91a6c5a18c202ef 
  storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java PRE-CREATION 
  storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66264/diff/2/

Changes: https://reviews.apache.org/r/66264/diff/1-2/


Testing
-------


Thanks,

Jesús Camacho Rodríguez