[GitHub] [fineract] galovics opened a new pull request, #2307: Sonar test

[GitBox <gi...@apache.org>]

galovics opened a new pull request, #2307:
URL: https://github.com/apache/fineract/pull/2307

   ## Description
   
   Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics merged pull request #2307: Sonar fix

[GitBox <gi...@apache.org>]

galovics merged PR #2307:
URL: https://github.com/apache/fineract/pull/2307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on pull request #2307: [DO NOT MERGE] Sonar test

[GitBox <gi...@apache.org>]

galovics commented on PR #2307:
URL: https://github.com/apache/fineract/pull/2307#issuecomment-1114789308

   @ptuomola @vidakovic just a note for you guys since you've probably seen that the Sonarqube builds for PRs are failing. Here's the reason why: upon a fork PR's GH Action, the action doesn't have access to the repo's configured secrets and this is mentioned in the GH docs:
   ```
   Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
   ```
   Meaning that the Sonarqube related secrets (including the token as well) are inaccessible unless the forkee's repo has the same set of secrets.
   
   I limited the sonarqube action to run after a PR merge and only on the develop branch for now.
   
   A proper solution would be to go back to Travis (or to any other external system where the secrets are not managed by GH) and run the sonar scan there but we gotta be careful not running into the same walls as originally; like with Travis, build slowness with the free pricing plan. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org