You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thomas Andraschko (Jira)" <de...@myfaces.apache.org> on 2023/02/28 17:05:00 UTC

[jira] [Commented] (MYFACES-4233) Support generics return type on myfaces-builder-plugin

    [ https://issues.apache.org/jira/browse/MYFACES-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694650#comment-17694650 ] 

Thomas Andraschko commented on MYFACES-4233:
--------------------------------------------

in theory we can also think about removing the plugin completley
JSF core doesnt have many components, its ok to manually maintain the sources
we do it in PF with MUCH more components and works great

> Support generics return type on myfaces-builder-plugin
> ------------------------------------------------------
>
>                 Key: MYFACES-4233
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4233
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-372
>            Reporter: Eduardo Breijo
>            Assignee: Paul Nicolucci
>            Priority: Minor
>
> On the JIRA issue below, there was an issue with the _UIWebsocket.getEventNames() method where the generic <String> in the return type of the method was missing in the auto-generated file UIWebsocket.
> {code:java}
> //BEGIN CODE COPIED FROM javax.faces.component._UIWebsocket 
> public java.util.Collection getEventNames()
> {code}
> JIRA issue: https://issues.apache.org/jira/browse/MYFACES-4232
>  
> To workaround this, the api/src/main/resources/META-INF/componentClass20.vm file was modified to actually generate the getEventNames() method with the correct return type. 
>  
> But I think we should fix this in the myfaces-builder-plugin, and then revert back the changes in the componentClass20.vm and javax.faces.component._UIWebsocket files.
>  
> I'm not familiar with the myfaces-builder-plugin, so any help here would be appreciated.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)