[GitHub] dawidwys commented on a change in pull request #7328: [FLINK-11191][table] Check for ambiguous columns in MATCH_RECOGNIZE

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #7328: [FLINK-11191][table] Check for ambiguous columns in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7328#discussion_r242827358
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamMatchRule.scala
 ##########
 @@ -91,6 +93,31 @@ class DataStreamMatchRule
     expr.foreach(_.accept(validator))
   }
 
+  private def validateAmbigousColumns(logicalMatch: FlinkLogicalMatch): Unit = {
+    val actualSize = logicalMatch.getPartitionKeys.size() + logicalMatch.getMeasures.size()
+    val expectedSize = logicalMatch.getRowType.getFieldCount
+    if (actualSize != expectedSize) {
 
 Review comment:
   We do not support `ALL ROWS PER MATCH`, I have to move a validation for that into this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services