[GitHub] [systemds] ywcb00 commented on a change in pull request #1218: [SYSTEMDS-2922] Federated Fused Codegen Operator - Rowwise

[GitBox <gi...@apache.org>]

ywcb00 commented on a change in pull request #1218:
URL: https://github.com/apache/systemds/pull/1218#discussion_r613273014



##########
File path: src/main/java/org/apache/sysds/runtime/instructions/fed/FEDInstructionUtils.java
##########
@@ -220,8 +221,11 @@ else if(inst instanceof QuaternaryCPInstruction) {
 		}
 		else if(inst instanceof SpoofCPInstruction) {
 			SpoofCPInstruction instruction = (SpoofCPInstruction) inst;
-			if(instruction.getOperatorClass().getSuperclass() == SpoofCellwise.class && instruction.isFederated(ec))
+			if((instruction.getOperatorClass().getSuperclass() == SpoofCellwise.class
+					|| instruction.getOperatorClass().getSuperclass() == SpoofRowwise.class)
+				&& instruction.isFederated(ec)) {

Review comment:
       Column partitioned federated data is not supported within federated rowwise spoof instructions.
   You're right, if we want to support column paritioned federated data as well (even without a federated instruction), we need to add a verification here, such that we don't replace the spoof instruction with a federated spoof instruction.
   Thanks, I will add this :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org