Re: [PR] feat(schema): Migrate HoodieRecord methods to use HoodieSchema instead of Avro.Schema [hudi]

["KiteSoar (via GitHub)" <gi...@apache.org>]

KiteSoar commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2658782265


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/CopyOnWriteInsertHandler.java:
##########
@@ -82,7 +82,7 @@ public void consume(HoodieInsertValueGenResult<HoodieRecord> genResult) {
     String partitionPath = record.getPartitionPath();
     // just skip the ignored record，do not make partitions on fs
     try {
-      if (record.shouldIgnore(genResult.schema, config.getProps())) {
+      if (record.shouldIgnore(HoodieSchema.fromAvroSchema(genResult.schema), config.getProps())) {

Review Comment:
   This is a good suggestion, but it involves refactoring the `HoodieInsertValueGenResult` class and modifying three client modules (Spark, Flink, and Java), which seems beyond the scope of the current pull request.  Wouldn't it be better to handle this as a separate task later?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org