Re: [PR] Fixes:#7837: Add isolationMethods and vlan to TrafficTypeResponse [cloudstack]

["madhukar93 (via GitHub)" <gi...@apache.org>]

madhukar93 commented on code in PR #8151:
URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1378379019


##########
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java:
##########
@@ -27,14 +27,13 @@
 import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
-import org.apache.cloudstack.api.response.ProviderResponse;
 import org.apache.cloudstack.api.response.TrafficTypeResponse;
 
 import com.cloud.network.PhysicalNetworkTrafficType;
 import com.cloud.user.Account;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = ProviderResponse.class, since = "3.0.0",
+@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = TrafficTypeResponse.class, since = "3.0.0",

Review Comment:
   @rohityadavcloud I can revert this, but won't the clients not be able to depend on the fields from `ProviderResponse` anyway, since they aren't set.
   
   @kishankavala I'm not sure how this attribute is used. Cloudmonkey doesn't seem to use it. Is this used for programmatic client generation and docs generation generally, but not for cmk? The one test that uses this API doesn't seem to care about the attributes in the response
   
   This is causing confusion for the reporter in the related issue as well - https://github.com/apache/cloudstack/issues/7837#issuecomment-1672122978
   
   I can revert this and maybe this should exist as a separate issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org