You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by fr...@apache.org on 2026/09/24 08:37:08 UTC
(logging-log4net) 01/01: stop appenders losing or leaking what they write - #324
This is an automated email from the ASF dual-hosted git repository.
FreeAndNil pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git
commit 3e6bf8d0d55853b471a5c912457f1dae55e1934c
Merge: fcdfc78d 5049c46f
Author: Jan Friedrich <43...@users.noreply.github.com>
AuthorDate: Thu Sep 24 10:37:01 2026 +0200
stop appenders losing or leaking what they write - #324
## Fixed
- **An oversize event was dropped by the UDP appenders**, audit da18b6fd-f015
- the socket rejects a payload over 65507 bytes, measured here: 65507 is sent, 65508 fails
- new `MaxDatagramSize`, default 65507, configurable from 512
- the event is cut on a character boundary, marked `...[truncated]` and reported
- not raisable: IPv6 would carry 20 bytes more, not worth a second limit
- **The configurator echoed secret values**, audit da18b6fd-f042
- a parameter named like a secret is now logged as `*****`
- a connection string keeps only the keywords that name the server
- covers internal debugging and the four setter failures, which are written without it
- `AdoNetAppender`'s allowlist moved to `log4net.Util.Redact` and is now shared
- **The pickup mail carried an SMTP DATA terminator**, audit da18b6fd-f037
- the file is read to its end, so the lone dot was delivered as a literal line
- it is gone; body lines stay verbatim and are not dot stuffed
- an agent that expects DATA framing is documented as not a supported consumer
.../3.5.0/324-config-debug-secret-values.xml | 14 +++
.../3.5.0/324-pickup-dir-dot-terminator.xml | 14 +++
.../3.5.0/324-udp-oversize-truncation.xml | 14 +++
.../Appender/RemoteSyslogAppenderTest.cs | 22 +++-
.../Appender/SmtpPickupDirAppenderTest.cs | 23 ++++
src/log4net.Tests/Appender/UdpAppenderTest.cs | 121 +++++++++++++++++++
src/log4net.Tests/Config/RedactTest.cs | 134 +++++++++++++++++++++
src/log4net/Appender/AdoNetAppender.cs | 66 +---------
src/log4net/Appender/RemoteSyslogAppender.cs | 2 +-
src/log4net/Appender/SmtpPickupDirAppender.cs | 3 +-
src/log4net/Appender/UdpAppender.cs | 89 +++++++++++++-
.../Hierarchy/XmlHierarchyConfigurator.cs | 18 +--
src/log4net/Util/Redact.cs | 131 ++++++++++++++++++++
.../appenders/remotesyslogappender.adoc | 1 +
.../appenders/smtppickupdirappender.adoc | 4 +
.../configuration/appenders/udpappender.adoc | 8 +-
src/site/antora/modules/ROOT/pages/manual/faq.adoc | 2 +
17 files changed, 587 insertions(+), 79 deletions(-)