You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/05 18:46:17 UTC
[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work
viirya commented on a change in pull request #31337:
URL: https://github.com/apache/spark/pull/31337#discussion_r571176503
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
##########
@@ -169,7 +169,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
|Once strategy's idempotence is broken for batch ${batch.name}
|${sideBySide(plan.treeString, reOptimized.treeString).mkString("\n")}
""".stripMargin
- throw new TreeNodeException(reOptimized, message, null)
+ throw new AnalysisException(message)
Review comment:
Is this always an analysis exception? Seems to me it is not only for analyzer rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org