You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@cloudera.com> on 2013/06/20 03:43:17 UTC
Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/
-----------------------------------------------------------
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Description
-------
commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175
Author: Mengwei Ding <me...@cloudera.com>
Date: Wed Jun 19 17:56:57 2013 -0700
SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
:100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 bf26761... 47a3bfa... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
:100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... ac7b2cf... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... bd96454... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... 60d8378... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
:100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
This addresses bug SQOOP-675.
https://issues.apache.org/jira/browse/SQOOP-675
Diffs
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
client/src/main/resources/client-resource.properties b159757
docs/src/site/sphinx/CommandLineClient.rst 073d547
Diff: https://reviews.apache.org/r/11983/diff/
Testing
-------
Done several manual test for all these 3 commands and their options.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 20, 2013, 9:39 p.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java, line 49
> > <https://reviews.apache.org/r/11983/diff/1/?file=308901#file308901line49>
> >
> > Nit: Put this in a utility class?
Yes, I do think so! Thank you, Abe.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22190
-----------------------------------------------------------
On June 20, 2013, 1:43 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 1:43 a.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 bf26761... 47a3bfa... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... ac7b2cf... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... bd96454... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... 60d8378... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
> :100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-675.
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties b159757
> docs/src/site/sphinx/CommandLineClient.rst 073d547
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22190
-----------------------------------------------------------
I've only been able to briefly look at this review. So far so good. Please take into consideration the comments below.
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/11983/#comment45609>
Nit: Put this in a utility class?
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/11983/#comment45608>
Nit: Put this in a utility class?
- Abraham Elmahrek
On June 20, 2013, 1:43 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 1:43 a.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 bf26761... 47a3bfa... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... ac7b2cf... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... bd96454... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... 60d8378... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
> :100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-675.
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties b159757
> docs/src/site/sphinx/CommandLineClient.rst 073d547
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Jarek Cecho <ja...@apache.org>.
On June 21, 2013, 10:57 p.m., Mengwei Ding wrote:
> > Jarcec
>
> Will McQueen wrote:
> I'm away of 6 toplevel resources in the http request path (starting with "v1/"). They are:
> framework
> connector
> connection
> job
> submission
>
> (Am I missing any?)
>
> With this proposed change, does this mean that the 'submission' resources will be either removed, or replaced by other toplevel resources?
>
> Will McQueen wrote:
> 6=>5
Hi Will,
this change is only in client module and is not changing client API nor the protocol.
Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:12 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties 8a570a1
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Will McQueen <wi...@cloudera.com>.
On June 21, 2013, 10:57 p.m., Mengwei Ding wrote:
> > Jarcec
I'm away of 6 toplevel resources in the http request path (starting with "v1/"). They are:
framework
connector
connection
job
submission
(Am I missing any?)
With this proposed change, does this mean that the 'submission' resources will be either removed, or replaced by other toplevel resources?
- Will
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:12 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties 8a570a1
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 21, 2013, 10:57 p.m., Jarek Cecho wrote:
> > Hi Mengwei,
> > thank you very much for working on this JIRA!
> >
> > I would advise to stay consistent with other commands and keep the distinction between "command" and "function", eg. something like "start job", "stop job" and "status job". I know that we currently can't start anything else beyond job, but it might be interesting to keep that option for the future.
Cool. I wat thinking about this too. And your suggestions make thing easier. :)
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
On June 21, 2013, 5:51 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 5:51 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 5cc954a0e8594a1ddd667d06cc438100b44fe234
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 0538901... 519e571... M client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
> :100644 100644 6f62813... fce737c... M client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
> :100644 100644 04b240c... 7729363... M client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
> :100644 100644 cc4d546... fc6f4ff... M client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
> :100644 100644 18d3a70... c5b7911... M client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
> :100644 100644 736be20... 71553cd... M client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
> :100644 100644 32bca71... 3c9039a... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 b053339... 81a78b0... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
> :100644 100644 590e4e7... 4f9dfb4... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 bf26761... b148667... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... c076882... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... ef2cec6... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... f483569... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8556e2b... b6b15fd... M client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
> :100644 100644 425a53f... 8aa5d62... M client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java
> :000000 100644 0000000... ca6443b... A client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java
> :100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
> :100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-675.
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 0538901
> client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6f62813
> client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 04b240c
> client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java cc4d546
> client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java 18d3a70
> client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 736be20
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java b053339
> client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7
> client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java 8556e2b
> client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 425a53f
> client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> docs/src/site/sphinx/CommandLineClient.rst 073d547
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Will McQueen <wi...@cloudera.com>.
On June 21, 2013, 10:57 p.m., Mengwei Ding wrote:
> > Jarcec
>
> Will McQueen wrote:
> I'm away of 6 toplevel resources in the http request path (starting with "v1/"). They are:
> framework
> connector
> connection
> job
> submission
>
> (Am I missing any?)
>
> With this proposed change, does this mean that the 'submission' resources will be either removed, or replaced by other toplevel resources?
6=>5
- Will
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:12 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties 8a570a1
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this JIRA!
I would advise to stay consistent with other commands and keep the distinction between "command" and "function", eg. something like "start job", "stop job" and "status job". I know that we currently can't start anything else beyond job, but it might be interesting to keep that option for the future.
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
<https://reviews.apache.org/r/11983/#comment45772>
I think that this if is missing:
... && has_option(jid)
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
<https://reviews.apache.org/r/11983/#comment45773>
I would suggest to propagate the InterruptedException up. It will be eventually caught up by the shell and based on the user configuration printed with or without details (stack trace).
client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java
<https://reviews.apache.org/r/11983/#comment45774>
I do not feel that this refactoring is providing a huge value here. All the methods were already present only once in parent implementation of all commands and thus were reused.
Jarcec
- Jarek Cecho
On June 21, 2013, 5:51 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 5:51 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 5cc954a0e8594a1ddd667d06cc438100b44fe234
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 0538901... 519e571... M client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
> :100644 100644 6f62813... fce737c... M client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
> :100644 100644 04b240c... 7729363... M client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
> :100644 100644 cc4d546... fc6f4ff... M client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
> :100644 100644 18d3a70... c5b7911... M client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
> :100644 100644 736be20... 71553cd... M client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
> :100644 100644 32bca71... 3c9039a... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 b053339... 81a78b0... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
> :100644 100644 590e4e7... 4f9dfb4... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 bf26761... b148667... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... c076882... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... ef2cec6... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... f483569... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8556e2b... b6b15fd... M client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
> :100644 100644 425a53f... 8aa5d62... M client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java
> :000000 100644 0000000... ca6443b... A client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java
> :100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
> :100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-675.
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
> client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 0538901
> client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6f62813
> client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 04b240c
> client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java cc4d546
> client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java 18d3a70
> client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 736be20
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71
> client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java b053339
> client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7
> client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java 8556e2b
> client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 425a53f
> client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java PRE-CREATION
> client/src/main/resources/client-resource.properties b159757
> docs/src/site/sphinx/CommandLineClient.rst 073d547
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 29, 2013, 9:43 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java, lines 70-74
> > <https://reviews.apache.org/r/11983/diff/4/?file=312990#file312990line70>
> >
> > I would suggest to not catch this exception and let it propagate to the shell itself. We do have exception callbacks defined so the exception will be processed correctly.
Sorry, Jarcec. I am pretty sure that I changed the code here. It seems like I made a mistake with the commit version when I update this code review. Now, fixed.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22541
-----------------------------------------------------------
On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:12 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties 8a570a1
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22541
-----------------------------------------------------------
Hi Mengwei,
thank you for incorporating my suggestions! I do have couple of last nits:
client/src/main/java/org/apache/sqoop/client/core/Constants.java
<https://reviews.apache.org/r/11983/#comment46284>
Nit: Most of the properties seems to be unused, can we remove them?
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
<https://reviews.apache.org/r/11983/#comment46285>
Nit: Please clean up unused imports.
client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
<https://reviews.apache.org/r/11983/#comment46283>
I would suggest to not catch this exception and let it propagate to the shell itself. We do have exception callbacks defined so the exception will be processed correctly.
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
<https://reviews.apache.org/r/11983/#comment46286>
Nit: Please clean up unused imports.
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
<https://reviews.apache.org/r/11983/#comment46287>
Nit: Please clean up unused imports.
Jarcec
- Jarek Cecho
On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:12 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties 8a570a1
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22614
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On July 1, 2013, 4:53 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 4:53 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-675
> https://issues.apache.org/jira/browse/SQOOP-675
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 93eeb1225d6be0d95783ce6da5b8fd6e3d9fe986
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Wed Jun 19 17:56:57 2013 -0700
>
> SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 944fb49... d96f44e... M client/src/main/java/org/apache/sqoop/client/core/ClientError.java
> :100644 100644 085fcdb... b7b0436... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 7293f56... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 2e1c8d3... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 5aab035... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 154c58e... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 a27d246... 5537a8e... M client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/ClientError.java 944fb49
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 085fcdb
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
> client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
> client/src/main/resources/client-resource.properties a27d246
> docs/src/site/sphinx/CommandLineClient.rst a14898f
>
> Diff: https://reviews.apache.org/r/11983/diff/
>
>
> Testing
> -------
>
> Done several manual test for all these 3 commands and their options.
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/
-----------------------------------------------------------
(Updated July 1, 2013, 4:53 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
Remove unused imports.
Bugs: SQOOP-675
https://issues.apache.org/jira/browse/SQOOP-675
Repository: sqoop-sqoop2
Description (updated)
-------
commit 93eeb1225d6be0d95783ce6da5b8fd6e3d9fe986
Author: Mengwei Ding <me...@cloudera.com>
Date: Wed Jun 19 17:56:57 2013 -0700
SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
:100644 100644 944fb49... d96f44e... M client/src/main/java/org/apache/sqoop/client/core/ClientError.java
:100644 100644 085fcdb... b7b0436... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... 7293f56... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... 2e1c8d3... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
:000000 100644 0000000... 5aab035... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
:000000 100644 0000000... 154c58e... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
:100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 a27d246... 5537a8e... M client/src/main/resources/client-resource.properties
:100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/ClientError.java 944fb49
client/src/main/java/org/apache/sqoop/client/core/Constants.java 085fcdb
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
client/src/main/resources/client-resource.properties a27d246
docs/src/site/sphinx/CommandLineClient.rst a14898f
Diff: https://reviews.apache.org/r/11983/diff/
Testing
-------
Done several manual test for all these 3 commands and their options.
Thanks,
Mengwei Ding
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/
-----------------------------------------------------------
(Updated June 28, 2013, 5:12 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
improved the documentation.
Bugs: SQOOP-675
https://issues.apache.org/jira/browse/SQOOP-675
Repository: sqoop-sqoop2
Description (updated)
-------
commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
Author: Mengwei Ding <me...@cloudera.com>
Date: Wed Jun 19 17:56:57 2013 -0700
SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
:100644 100644 06f8162... 5c12316... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... 3d8889f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... 1ffda46... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
:000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
:000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
:100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 8a570a1... c7b2324... M client/src/main/resources/client-resource.properties
:100644 100644 a14898f... 22d6d47... M docs/src/site/sphinx/CommandLineClient.rst
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
client/src/main/resources/client-resource.properties 8a570a1
docs/src/site/sphinx/CommandLineClient.rst a14898f
Diff: https://reviews.apache.org/r/11983/diff/
Testing
-------
Done several manual test for all these 3 commands and their options.
Thanks,
Mengwei Ding
Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/
-----------------------------------------------------------
(Updated June 26, 2013, 4:14 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
change back these commands to support "job" function.
Bugs: SQOOP-675
https://issues.apache.org/jira/browse/SQOOP-675
Repository: sqoop-sqoop2
Description (updated)
-------
commit 2f60a509f34d37293e79b15db7d233752aef3093
Author: Hari Shreedharan <hs...@apache.org>
Date: Tue Jun 25 16:24:53 2013 -0700
SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
:100644 100644 944fb49... 7af7b58... M client/src/main/java/org/apache/sqoop/client/core/ClientError.java
:100644 100644 06f8162... e34c55e... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... a44b09f... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... 9fceeb6... A client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
:000000 100644 0000000... 0be574e... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... b854a90... A client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
:000000 100644 0000000... 2537438... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:000000 100644 0000000... 49ab461... A client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
:100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 29144d1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 8a570a1... aca278a... M client/src/main/resources/client-resource.properties
:100755 100755 d909b7f... b826450... M dev-support/test-patch.py
:100644 100644 a14898f... 97916a1... M docs/src/site/sphinx/CommandLineClient.rst
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/ClientError.java 944fb49
client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
client/src/main/resources/client-resource.properties 8a570a1
docs/src/site/sphinx/CommandLineClient.rst a14898f
Diff: https://reviews.apache.org/r/11983/diff/
Testing
-------
Done several manual test for all these 3 commands and their options.
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start',
'stop' and 'status' cmds.
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/
-----------------------------------------------------------
(Updated June 21, 2013, 5:51 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Changes
-------
Move parseOptions() and getLong() static methods to a new created util class "OptionParser".
Description (updated)
-------
commit 5cc954a0e8594a1ddd667d06cc438100b44fe234
Author: Mengwei Ding <me...@cloudera.com>
Date: Wed Jun 19 17:56:57 2013 -0700
SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
:100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 0538901... 519e571... M client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
:100644 100644 6f62813... fce737c... M client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
:100644 100644 04b240c... 7729363... M client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
:100644 100644 cc4d546... fc6f4ff... M client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
:100644 100644 18d3a70... c5b7911... M client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
:100644 100644 736be20... 71553cd... M client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
:100644 100644 32bca71... 3c9039a... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 b053339... 81a78b0... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
:100644 100644 590e4e7... 4f9dfb4... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 bf26761... b148667... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
:100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... c076882... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... ef2cec6... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... f483569... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 1a6d896... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 8556e2b... b6b15fd... M client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
:100644 100644 425a53f... 8aa5d62... M client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java
:000000 100644 0000000... ca6443b... A client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java
:100644 100644 b159757... 2092a33... M client/src/main/resources/client-resource.properties
:100644 100644 073d547... a103277... M docs/src/site/sphinx/CommandLineClient.rst
This addresses bug SQOOP-675.
https://issues.apache.org/jira/browse/SQOOP-675
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 0538901
client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6f62813
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 04b240c
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java cc4d546
client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java 18d3a70
client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 736be20
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 32bca71
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java b053339
client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 590e4e7
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01
client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java 8556e2b
client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 425a53f
client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java PRE-CREATION
client/src/main/resources/client-resource.properties b159757
docs/src/site/sphinx/CommandLineClient.rst 073d547
Diff: https://reviews.apache.org/r/11983/diff/
Testing
-------
Done several manual test for all these 3 commands and their options.
Thanks,
Mengwei Ding