You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "heyihong (via GitHub)" <gi...@apache.org> on 2025/11/14 15:48:45 UTC

Re: [PR] [SPARK-54353][SQL] Make CollectMetricsExec.collectedMetrics thread-safe [spark]

heyihong commented on PR #53064:
URL: https://github.com/apache/spark/pull/53064#issuecomment-3533387482

   > @heyihong please fix the locking in CollectMetricsExec. Get the value out of the accumulator and move into a a synchronized field. This change as is will cause performance regression throughout the engine.
   
   The accumulator also needs synchronization because accumulator.value is not thread-safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org