You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/06 13:00:54 UTC

[GitHub] [spark] PavithraRamachandran commented on a change in pull request #26364: [SPARK-29601][WEBUI] JDBC ODBC Tab Statement column provide ellipsis for big SQL statement

PavithraRamachandran commented on a change in pull request #26364: [SPARK-29601][WEBUI] JDBC ODBC Tab Statement column provide ellipsis for big SQL statement
URL: https://github.com/apache/spark/pull/26364#discussion_r343080872
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
 ##########
 @@ -347,7 +347,9 @@ private[ui] class SqlStatsPagedTable(
         {formatDurationVerbose(duration)}
       </td>
       <td>
-        {info.statement}
+        <span class="description-input">
 
 Review comment:
   yes it shows full query when clicked. 
   In jobs page , stage page also similar ellipsis is present. But we don't have expand all in those pages too.
   @srowen could you suggest if expand all needs to added in all the places for consistency?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org