[GitHub] [hive] pvary commented on a change in pull request #1343: HIVE-23960 : Partition with no column statistics leads to unbalanced …

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1343:
URL: https://github.com/apache/hive/pull/1343#discussion_r463591370



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -6993,11 +6993,16 @@ public GetPartitionsByNamesResult get_partitions_by_names_req(GetPartitionsByNam
           // request them separately.
           for (Partition part: ret) {
             String partName = Warehouse.makePartName(table.getPartitionKeys(), part.getValues());
-            List<ColumnStatistics> partColStatsList =
-                    getMS().getPartitionColumnStatistics(parsedCatName, parsedDbName, tblName,
-                            Collections.singletonList(partName),
-                            StatsSetupConst.getColumnsHavingStats(part.getParameters()),
-                            engine);
+            List<ColumnStatistics> partColStatsList = null;
+            List<String> colNames = StatsSetupConst.getColumnsHavingStats(part.getParameters());

Review comment:
       Might be a good idea to push this check inside the getPartitionColumnStatistics




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org