You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2014/04/26 09:01:08 UTC

RE: svn commit: r1544690 - in /subversion/trunk/subversion:libsvn_wc/status.c libsvn_wc/wc-queries.sql libsvn_wc/wc_db.clibsvn_wc/wc_db.h tests/cmdline/stat_tests.py

Accurate is probably the best completion, as the old version missed a few corner cases that really needed more info from wc.db.

Bert

-----Original Message-----
From: "Ben Reser" <be...@reser.org>
Sent: ‎26-‎4-‎2014 03:48
To: "Subversion Development" <de...@subversion.apache.org>
Subject: Re: svn commit: r1544690 - in /subversion/trunk/subversion:libsvn_wc/status.c libsvn_wc/wc-queries.sql libsvn_wc/wc_db.clibsvn_wc/wc_db.h tests/cmdline/stat_tests.py

On 11/22/13, 1:49 PM, rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Fri Nov 22 21:49:46 2013
> New Revision: 1544690
> 
> URL: http://svn.apache.org/r1544690
> Log:
> Fix a very ugly case in 'svn status' where 'svn status wc' and
> 'svn status wc/path' could show a different status for path.
> 
> This also makes 'svn status' always describe the highest moved_to when
> there are multiple moves from a single location.
> (This behavior was undefined before, but identical to what you would get with
>  the usual index usage in sqlite)
> 
> This patch has the nice side effect that it resolves the most common crash
> report in the current AnkhSVN version: an assertion caused by an invalid
> move stored in wc.db.
> 
> * subversion/libsvn_wc/status.c
>   (read_info): Move this function into wc_db.c to allow using a lock and
>     access to private apis.
>   (assemble_status): Update caller. Update moved_to usage.
>   (get_dir_status,
>    get_child_status,
>    svn_wc__internal_walk_status): Update caller.
> 
> * subversion/libsvn_wc/wc-queries.sql
>   (STMT_SELECT_MOVED_TO_NODE): New query.
> 
> * subversion/libsvn_wc/wc_db.c
>   (read_children_info): Set moved_here as documented: only for op-roots.
>     Don't duplicate name for every higher layer.
>     Hook moved_to information in a linked list, to provide users all move
>     information.
>   (read_single_info,
>    svn_wc__db_read_single_info): New function. Based on status' read_info,
>      but more

[snip]

More what?  Seems that part of that sentence is missing.  Based on the context
I'm guessing more accurate?