[GitHub] [maven-surefire] Tibor17 edited a comment on issue #238: [SUREFIRE-1670] wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page

[GitBox <gi...@apache.org>]

Tibor17 edited a comment on issue #238: [SUREFIRE-1670] wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page
URL: https://github.com/apache/maven-surefire/pull/238#issuecomment-498288378
 
 
   @msakamoto-sf 
   I am sorry to say we have to do it once again.
   The VM file has an ability to understand IF-ELSE branching. So there's no reason to write two chapters. As a hint see the branching here (spaces matter) https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/index.apt.vm#L78
   Pls keep only single commit in PR, up to date with HEAD of remote origin/master (we pushed into a while ago).
   check the site, how it looks like when you build it with `mvn install site -DskipTests -DskipITs`. The sites will be separated in every module `$module/target/site/index.html`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services