You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2018/05/04 03:23:23 UTC

[GitHub] spark pull request #21195: [Spark-23975][ML] Add support of array input for ...

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21195#discussion_r185971385
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala ---
    @@ -101,4 +102,17 @@ private[spark] object SchemaUtils {
         require(!schema.fieldNames.contains(col.name), s"Column ${col.name} already exists.")
         StructType(schema.fields :+ col)
       }
    +
    +  /**
    +   * Check whether the given column in the schema is one of the supporting vector type: Vector,
    +   * Array[Dloat]. Array[Double]
    --- End diff --
    
    nit: Float


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org