You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/02 13:35:19 UTC

[GitHub] [airflow] potiuk opened a new pull request, #24112: Temporarily fix bitnami index problem

potiuk opened a new pull request, #24112:
URL: https://github.com/apache/airflow/pull/24112

We started to experience "Internal Error" when installing
Helm chart and apperently bitnami "solved" the problem by
removing from their index software older than 6 months(!).

This makes our CI fail but It is much worse. This
renders all our charts useless for people to install
This is terribly wrong, and I raised this in the issue
here:

https://github.com/bitnami/charts/issues/10539#issuecomment-1144869092

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

potiuk commented on code in PR #24112:
URL: https://github.com/apache/airflow/pull/24112#discussion_r887971591


##########
chart/Chart.yaml:
##########
@@ -35,7 +35,8 @@ keywords:
 dependencies:
   - name: postgresql
     version: 10.5.3
-    repository: "https://raw.githubusercontent.com/bitnami/charts/index/bitnami"
+    repository: >
+      https://raw.githubusercontent.com/bitnami/charts/eb5f9a9513d987b519f0ecd732e7031241c50328/bitnami

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

potiuk commented on code in PR #24112:
URL: https://github.com/apache/airflow/pull/24112#discussion_r887969011


##########
chart/Chart.yaml:
##########
@@ -35,7 +35,8 @@ keywords:
 dependencies:
   - name: postgresql
     version: 10.5.3
-    repository: "https://raw.githubusercontent.com/bitnami/charts/index/bitnami"
+    repository: >
+      https://raw.githubusercontent.com/bitnami/charts/eb5f9a9513d987b519f0ecd732e7031241c50328/bitnami

Review Comment:
   I hope it's temporary actually but you are right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #24112:
URL: https://github.com/apache/airflow/pull/24112#issuecomment-1144895977

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #24112:
URL: https://github.com/apache/airflow/pull/24112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #24112:
URL: https://github.com/apache/airflow/pull/24112#issuecomment-1144897730

   Let me merge it quickly without waiting - It cannot get worse than the current situation :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bergerx commented on a diff in pull request #24112: Temporarily fix bitnami index problem

Posted by GitBox <gi...@apache.org>.

bergerx commented on code in PR #24112:
URL: https://github.com/apache/airflow/pull/24112#discussion_r887968543


##########
chart/Chart.yaml:
##########
@@ -35,7 +35,8 @@ keywords:
 dependencies:
   - name: postgresql
     version: 10.5.3
-    repository: "https://raw.githubusercontent.com/bitnami/charts/index/bitnami"
+    repository: >
+      https://raw.githubusercontent.com/bitnami/charts/eb5f9a9513d987b519f0ecd732e7031241c50328/bitnami

Review Comment:
   Better if you include an explanation here, about why there is a weird magic number here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org