You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/02/19 03:01:35 UTC
zeppelin git commit: [ZEPPELIN-2120] Flaky Test:
NotebookTest.testRunAll
Repository: zeppelin
Updated Branches:
refs/heads/master cbe2ef4f9 -> bd3b05316
[ZEPPELIN-2120] Flaky Test: NotebookTest.testRunAll
### What is this PR for?
Fix Flaky test NotebookTest.testRunAll
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix flaky test
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2120
### How should this be tested?
check ci becomes green
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <mo...@apache.org>
Closes #2022 from Leemoonsoo/ZEPPELIN-2120 and squashes the following commits:
7ee7feb [Lee moon soo] wait while result is null
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/bd3b0531
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/bd3b0531
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/bd3b0531
Branch: refs/heads/master
Commit: bd3b05316ff674e864d0af958537884169fda771
Parents: cbe2ef4
Author: Lee moon soo <mo...@apache.org>
Authored: Thu Feb 16 00:25:01 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Sun Feb 19 12:01:30 2017 +0900
----------------------------------------------------------------------
.../src/test/java/org/apache/zeppelin/notebook/NotebookTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/bd3b0531/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
index c3ba905..f62315c 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
@@ -320,7 +320,7 @@ public class NotebookTest implements JobListenerFactory{
note.runAll();
// wait for finish
- while(p3.isTerminated() == false) {
+ while(p3.isTerminated() == false || p3.getResult() == null) {
Thread.yield();
}