You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 16:17:27 UTC

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6818: risc-v: Implement riscv_sbi_set_timer

pussuw commented on code in PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818#discussion_r941544577


##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -33,24 +45,30 @@
  * Private Functions
  ****************************************************************************/
 
-#ifdef CONFIG_ARCH_RV64
-static inline uint64_t rdtime(void)
+static inline uintptr_t sbi_ecall(unsigned int extid, unsigned int fid,

Review Comment:
   Sure it can be done. Do you anticipate the definition will be needed by other source files ? My original idea was to put all SBI calls in this file but I don't know if e.g. OpenAMP or some IPI-interface etc. will need this ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org