You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/03 18:49:48 UTC

[GitHub] [accumulo] dlmarion commented on a change in pull request #2143: Fix external compaction properties names and keys

dlmarion commented on a change in pull request #2143:
URL: https://github.com/apache/accumulo/pull/2143#discussion_r645047747



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
       "The maximum size of a message that can be sent to a tablet server."),
   // CompactionCoordinator properties
   @Experimental
-  COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+  COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null, PropertyType.PREFIX,

Review comment:
       My initial inclination was to use a `-` (dash), but could not find an example of this being done elsewhere. I would rather see `compaction-coordinator` vs `compaction.coordinator`.
   
   I guess another convention that's not mentioned is to use the first letter and second word in a multi-word server name (tablet server -> tserver). I suppose I could use `ccoordinator`
   (just kidding)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org